Page MenuHomePhabricator

[compiler-rt][Darwin] Refactor minimum deployment target substitutions
ClosedPublic

Authored by yln on Aug 13 2020, 12:32 PM.

Details

Summary
  • Support macOS 11+ version scheme
  • Standardize substitution name %min_deployment_target=x.y
  • Remove unneeded error cases (the input version is hard-coded)
  • Specify version as tuple instead of string; no need to parse it

These changes should also facilitate a future addition of a substitution
that expands to "set deployment target to current target version"
(https://reviews.llvm.org/D70151).

Diff Detail

Event Timeline

yln created this revision.Aug 13 2020, 12:32 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 13 2020, 12:32 PM
Herald added subscribers: Restricted Project, dberris. · View Herald Transcript
yln requested review of this revision.Aug 13 2020, 12:32 PM

LGTM. Other than the nit.

compiler-rt/test/lit.common.cfg.py
340

Nit: min_deployment_target is a very general sounding thing but in this context its Darwin specific. You might want to put macos or darwin in the name somewhere to make this clear.

yln marked an inline comment as done.Aug 20 2020, 3:41 PM
yln added inline comments.
compiler-rt/test/lit.common.cfg.py
340

Renaming %min_deployment_target -> %min_macos_deployment_target.

This revision was not accepted when it landed; it landed in state Needs Review.Aug 20 2020, 4:23 PM
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
yln marked an inline comment as done.