HomePhabricator

[ELF] Keep st_type for symbol assignment

Authored by MaskRay on Aug 20 2020, 4:05 PM.

Description

[ELF] Keep st_type for symbol assignment

PR46970: for alias = aliasee, the alias can be used in relocation processing
and on ARM st_type does affect Thumb interworking. It is thus desirable for the
alias to get the same st_type.

Note that the st_size field should not be inherited because some tools use
st_size=0 as a heuristic to detect aliases. Retaining st_size can thwart such
heuristics and cause aliases to be preferred over the original symbols.

Differential Revision: https://reviews.llvm.org/D86263

Details