Page MenuHomePhabricator

Add cold attribute to one time construction APIs
ClosedPublic

Authored by hiraditya on Aug 12 2020, 10:14 PM.

Details

Summary

__cxa_guard_acquire is used for only one purpose, namely guarding local static variable initialization, and since that purpose is definitionally cold, it should be attributed as cold.
Similarly for __cxa_guard_release and __cxa_guard_abort

Diff Detail

Event Timeline

hiraditya created this revision.Aug 12 2020, 10:14 PM
hiraditya requested review of this revision.Aug 12 2020, 10:14 PM
hiraditya edited the summary of this revision. (Show Details)Aug 12 2020, 10:30 PM
ldionne accepted this revision.Aug 13 2020, 5:42 AM
This revision is now accepted and ready to land.Aug 13 2020, 5:42 AM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptAug 13 2020, 9:30 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript