This is an archive of the discontinued LLVM Phabricator instance.

Differential D85860

[HotColdSplit] Fix variable name spelling
ClosedPublic

Authored by rjf on Aug 12 2020, 4:01 PM.

Details

Reviewers
hiraditya
vsk
rcorcs
Summary

Rename EnableStaticAnalyis to EnableStaticAnalysis.

Diff Detail

Event Timeline

rjf created this revision.Aug 12 2020, 4:01 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 12 2020, 4:01 PM
Herald added a subscriber: llvm-commits. · View Herald Transcript
rjf requested review of this revision.Aug 12 2020, 4:01 PM
Harbormaster completed remote builds in B68177: Diff 285202.Aug 12 2020, 4:50 PM
hiraditya accepted this revision.Aug 12 2020, 9:38 PM
This revision is now accepted and ready to land.Aug 12 2020, 9:38 PM
hiraditya added a comment.Aug 12 2020, 10:59 PM

Closed in:
f902a7eccf30a762d9a533c3884edfb692c26a09

Totally missed adding differential revision. sorry.

hiraditya closed this revision.Aug 12 2020, 10:59 PM

Revision Contents

PathSize
llvm/
lib/
Transforms/
IPO/
6 lines

Diff 285202

llvm/lib/Transforms/IPO/HotColdSplitting.cpp

Show First 20 Lines • Show All 72 Lines • ▼ Show 20 Lines
#define DEBUG_TYPE "hotcoldsplit" #define DEBUG_TYPE "hotcoldsplit"
STATISTIC(NumColdRegionsFound, "Number of cold regions found."); STATISTIC(NumColdRegionsFound, "Number of cold regions found.");
STATISTIC(NumColdRegionsOutlined, "Number of cold regions outlined."); STATISTIC(NumColdRegionsOutlined, "Number of cold regions outlined.");
using namespace llvm; using namespace llvm;
static cl::opt<bool> EnableStaticAnalyis("hot-cold-static-analysis", static cl::opt<bool> EnableStaticAnalysis("hot-cold-static-analysis",
cl::init(true), cl::Hidden); cl::init(true), cl::Hidden);
static cl::opt<int> static cl::opt<int>
SplittingThreshold("hotcoldsplit-threshold", cl::init(2), cl::Hidden, SplittingThreshold("hotcoldsplit-threshold", cl::init(2), cl::Hidden,
cl::desc("Base penalty for splitting cold code (as a " cl::desc("Base penalty for splitting cold code (as a "
"multiple of TCC_Basic)")); "multiple of TCC_Basic)"));
static cl::opt<bool> EnableColdSection( static cl::opt<bool> EnableColdSection(
"enable-cold-section", cl::init(false), cl::Hidden, "enable-cold-section", cl::init(false), cl::Hidden,
▲ Show 20 Lines • Show All 503 Lines • ▼ Show 20 Linesbool HotColdSplitting::outlineColdRegions(Function &F, bool HasProfileSummary) {
// Find all cold regions. // Find all cold regions.
for (BasicBlock *BB : RPOT) { for (BasicBlock *BB : RPOT) {
// This block is already part of some outlining region. // This block is already part of some outlining region.
if (ColdBlocks.count(BB)) if (ColdBlocks.count(BB))
continue; continue;
bool Cold = (BFI && PSI->isColdBlock(BB, BFI)) || bool Cold = (BFI && PSI->isColdBlock(BB, BFI)) ||
(EnableStaticAnalyis && unlikelyExecuted(*BB, PSI, BFI)); (EnableStaticAnalysis && unlikelyExecuted(*BB, PSI, BFI));
if (!Cold) if (!Cold)
continue; continue;
LLVM_DEBUG({ LLVM_DEBUG({
dbgs() << "Found a cold block:\n"; dbgs() << "Found a cold block:\n";
BB->dump(); BB->dump();
}); });
▲ Show 20 Lines • Show All 160 Lines • Show Last 20 Lines