[TSan][Darwin] Remove unnecessary lit substitution

[yln]

Summary

We don't test on very old versions of Apple platforms anymore. This lit
substitution concerning the minimum deployment target for ARC support
can be safely removed.

%darwin_min_target_with_full_runtime_arc_support -> 10.11

[delcypher]

@yln Are you sure this actually works for all platforms, in particular the watchOS simulator? The code you link (https://github.com/llvm/llvm-project/blob/master/compiler-rt/lib/tsan/CMakeLists.txt#L122) is not the minimum deploy target. That code just checks the SDK version used to build which is different from the minimum deploy target used.

The minimum deployment target for macOS is actually 10.10 I think (https://github.com/llvm/llvm-project/blob/master/compiler-rt/cmake/config-ix.cmake#L400). Other code sets the minimum deployment targets (https://github.com/llvm/llvm-project/blob/master/compiler-rt/cmake/config-ix.cmake#L363) for other platforms.

[yln]

In D85803#2216780, @delcypher wrote:

@yln Are you sure this actually works for all platforms, in particular the watchOS simulator? The code you link (https://github.com/llvm/llvm-project/blob/master/compiler-rt/lib/tsan/CMakeLists.txt#L122) is not the minimum deploy target. That code just checks the SDK version used to build which is different from the minimum deploy target used.

The minimum deployment target for macOS is actually 10.10 I think (https://github.com/llvm/llvm-project/blob/master/compiler-rt/cmake/config-ix.cmake#L400). Other code sets the minimum deployment targets (https://github.com/llvm/llvm-project/blob/master/compiler-rt/cmake/config-ix.cmake#L363) for other platforms.

You are completely right. The minimum deployment target for sanitizers is 10.10. For TSan, we require SDK 10.12+ to build. I confused myself here when I was writing the description for the patch. Let me try again:

The purpose of this patch is to cleanup our tests and deployment target lit substitutions as much as possible under the assumption that test execution itself does not happen on these very old versions anymore. We don't want to do anything that would intentionally break these old versions or raise the deployment target without justification, but testing them is not a priority anymore (we have stopped to do so), so our testing infrastructure doesn't need to support this anymore.

I will run ninja check-tsan check-tsan-iossim-x86_64 check-tsan-watchossim-x86_64 and adapt this patch accordingly.

[yln]

Keep %darwin_min_target_with_tls_support -> 10.12. TLS requires watchOS 3+ simulator.

compiler-rt/test/lit.common.cfg.py

if config.gwp_asan:
   config.available_features.add('gwp_asan')
 
 lit.util.usePlatformSdkOnDarwin(config, lit_config)
 
 # Maps a lit substitution name for the minimum target OS flag
 # to the macOS version that first contained the relevant feature.
 darwin_min_deployment_target_substitutions = {
   '%macos_min_target_10_11': '10.11',
-  # rdar://problem/22207160
-  '%darwin_min_target_with_full_runtime_arc_support': '10.11',
-  '%darwin_min_target_with_tls_support': '10.12',
 }
 
 if config.host_os == 'Darwin':
   def get_apple_platform_version_aligned_with(macos_version, apple_platform):
     """
       Given a macOS version (`macos_version`) returns the corresponding version for
       the specified Apple platform if it exists.
 

compiler-rt/test/tsan/Darwin/norace-objcxx-run-time.mm

-// RUN: %clang_tsan %s -lc++ -fobjc-arc -lobjc -o %t -framework Foundation %darwin_min_target_with_full_runtime_arc_support
+// RUN: %clang_tsan %s -lc++ -fobjc-arc -lobjc -o %t -framework Foundation
 // RUN: %env_tsan_opts=ignore_interceptors_accesses=1 %run %t 2>&1 | FileCheck %s
 
 // Check that we do not report races between:
 // - Object retain and initialize
 // - Object release and dealloc
 // - Object release and .cxx_destruct
 
 #import <Foundation/Foundation.h>

compiler-rt/test/tsan/Darwin/objc-synchronize-cycle-tagged.mm

-// RUN: %clangxx_tsan %s -o %t -framework Foundation -fobjc-arc %darwin_min_target_with_full_runtime_arc_support
+// RUN: %clangxx_tsan %s -o %t -framework Foundation -fobjc-arc
 // RUN:     %run %t 6 2>&1 | FileCheck %s --check-prefix=SIX
 // RUN: not %run %t 7 2>&1 | FileCheck %s --check-prefix=SEVEN
 
 #import <Foundation/Foundation.h>
 
 static bool isTaggedPtr(id obj) {
   uintptr_t ptr = (uintptr_t) obj;
   return (ptr & 0x8000000000000001ull) != 0;

compiler-rt/test/tsan/Darwin/objc-synchronize-cycle.mm

-// RUN: %clangxx_tsan %s -o %t -framework Foundation -fobjc-arc %darwin_min_target_with_full_runtime_arc_support
+// RUN: %clangxx_tsan %s -o %t -framework Foundation -fobjc-arc
 // RUN:                                   not %run %t 2>&1 | FileCheck %s
 // RUN: %env_tsan_opts=detect_deadlocks=1 not %run %t 2>&1 | FileCheck %s
 // RUN: %env_tsan_opts=detect_deadlocks=0     %run %t 2>&1 | FileCheck %s --check-prefix=DISABLED
 
 #import <Foundation/Foundation.h>
 
 int main() {
   @autoreleasepool {

compiler-rt/test/tsan/Darwin/objc-synchronize-nested-recursive.mm

-// RUN: %clangxx_tsan %s -o %t -framework Foundation -fobjc-arc %darwin_min_target_with_full_runtime_arc_support
+// RUN: %clangxx_tsan %s -o %t -framework Foundation -fobjc-arc
 // RUN: %run %t 2>&1 | FileCheck %s
 
 #import <Foundation/Foundation.h>
 
 int main() {
   @autoreleasepool {
     NSObject* obj1 = [NSObject new];
     NSObject* obj2 = [NSObject new];

compiler-rt/test/tsan/Darwin/objc-synchronize-tagged.mm

-// RUN: %clangxx_tsan %s -o %t -framework Foundation -fobjc-arc %darwin_min_target_with_full_runtime_arc_support
+// RUN: %clangxx_tsan %s -o %t -framework Foundation -fobjc-arc
 // RUN: %run %t 2>&1 | FileCheck %s
 
 #import <Foundation/Foundation.h>
 
 NSString *tagged_string = nil;
 
 @interface MyClass : NSObject {
   long field;

compiler-rt/test/tsan/Darwin/objc-synchronize.mm

-// RUN: %clangxx_tsan %s -o %t -framework Foundation -fobjc-arc %darwin_min_target_with_full_runtime_arc_support
+// RUN: %clangxx_tsan %s -o %t -framework Foundation -fobjc-arc
 // RUN: %run %t 2>&1 | FileCheck %s
 
 #import <Foundation/Foundation.h>
 
 @interface MyClass : NSObject {
   long field;
 }
 @property (nonatomic, readonly) long value;

compiler-rt/test/tsan/Darwin/os_unfair_lock.c

-// RUN: %clang_tsan %s -o %t -mmacosx-version-min=10.12
+// RUN: %clang_tsan %s -o %t
 // RUN: %run %t 2>&1 | FileCheck %s --implicit-check-not='ThreadSanitizer'
 
 // UNSUPPORTED: ios
 
 #include <os/lock.h>
 #include <pthread.h>
 #include <stdio.h>
 

compiler-rt/test/tsan/dtls.c

-// RUN: %clang_tsan %darwin_min_target_with_tls_support %s -o %t
-// RUN: %clang_tsan %darwin_min_target_with_tls_support %s -DBUILD_SO -fPIC -o \
-// RUN:   %t-so.so -shared
+// RUN: %clang_tsan %s -o %t
+// RUN: %clang_tsan %s -DBUILD_SO -fPIC -o %t-so.so -shared
 // RUN: %run %t 2>&1 | FileCheck %s
 // XFAIL: netbsd
 
 // Test that tsan cleans up dynamic TLS memory between reuse.
 
 #include "test.h"
 
 #ifndef BUILD_SO

compiler-rt/test/tsan/mutexset7.cpp

-// RUN: %clangxx_tsan %darwin_min_target_with_tls_support -O1 %s -o %t && \
-// RUN:   %deflake %run %t | FileCheck %s
+// RUN: %clangxx_tsan -O1 %s -o %t
+// RUN: %deflake %run %t | FileCheck %s
 #include "test.h"
 
 int Global;
 __thread int huge[1024*1024];
 
 void *Thread1(void *x) {
   barrier_wait(&barrier);
   Global++;

compiler-rt/test/tsan/tls_race.cpp

-// RUN: %clangxx_tsan %darwin_min_target_with_tls_support -O1 %s -o %t && \
-// RUN:   %deflake %run %t | \
+// RUN: %clangxx_tsan -O1 %s -o %t
+// RUN: %deflake %run %t | \
 // RUN:   FileCheck %s --check-prefix=CHECK-%os --check-prefix=CHECK
 #include "test.h"
 
 void *Thread(void *a) {
   barrier_wait(&barrier);
   *(int*)a = 43;
   return 0;
 }

compiler-rt/test/tsan/tls_race2.cpp

-// RUN: %clangxx_tsan %darwin_min_target_with_tls_support -O1 %s -o %t && \
-// RUN:   %deflake %run %t | \
+// RUN: %clangxx_tsan -O1 %s -o %t
+// RUN: %deflake %run %t | \
 // RUN:   FileCheck %s --check-prefix=CHECK-%os --check-prefix=CHECK
 #include "test.h"
 
 void *Thread2(void *a) {
   barrier_wait(&barrier);
   *(int*)a = 43;
   return 0;
 }