Page MenuHomePhabricator

[TSan][Darwin] Enable test on non-macOS platforms
ClosedPublic

Authored by yln on Aug 13 2020, 6:16 PM.

Details

Summary

After removing the unnecessary -mmacosx-version-min=10.12 compiler
flag this test can run on all platforms. I confirmed that this test is
green for iOS, iOS simulator, and watchOS simulator.

Diff Detail

Event Timeline

yln created this revision.Aug 13 2020, 6:16 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 13 2020, 6:16 PM
Herald added a subscriber: Restricted Project. · View Herald Transcript
yln requested review of this revision.Aug 13 2020, 6:16 PM

You should probably refer to https://reviews.llvm.org/D85803 or the commit that removed -mmacosx-version-min=10.12 in the commit message. Other than that LGTM. Thanks for cleaning this up.

delcypher accepted this revision.Aug 20 2020, 12:22 PM
This revision is now accepted and ready to land.Aug 20 2020, 12:22 PM
This revision was landed with ongoing or failed builds.Aug 20 2020, 12:42 PM
This revision was automatically updated to reflect the committed changes.