This is an archive of the discontinued LLVM Phabricator instance.

Differential D85952

[TSan][Darwin] Enable test on non-macOS platforms
ClosedPublic

Authored by yln on Aug 13 2020, 6:16 PM.

Details

Reviewers
delcypher
Commits
rG6222a28db5ed: [TSan][Darwin] Enable test on non-macOS platforms
Summary

After removing the unnecessary -mmacosx-version-min=10.12 compiler
flag this test can run on all platforms. I confirmed that this test is
green for iOS, iOS simulator, and watchOS simulator.

Diff Detail

Event Timeline

yln created this revision.Aug 13 2020, 6:16 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 13 2020, 6:16 PM
Herald added a subscriber: Restricted Project. · View Herald Transcript
yln requested review of this revision.Aug 13 2020, 6:16 PM
Harbormaster completed remote builds in B68359: Diff 285537.Aug 13 2020, 6:16 PM
delcypher added a comment.Aug 20 2020, 12:22 PM

You should probably refer to https://reviews.llvm.org/D85803 or the commit that removed -mmacosx-version-min=10.12 in the commit message. Other than that LGTM. Thanks for cleaning this up.

delcypher accepted this revision.Aug 20 2020, 12:22 PM
This revision is now accepted and ready to land.Aug 20 2020, 12:22 PM
This revision was landed with ongoing or failed builds.Aug 20 2020, 12:42 PM
Closed by commit rG6222a28db5ed: [TSan][Darwin] Enable test on non-macOS platforms (authored by yln). · Explain Why
This revision was automatically updated to reflect the committed changes.
yln added a commit: rG6222a28db5ed: [TSan][Darwin] Enable test on non-macOS platforms.

Revision Contents

PathSize
compiler-rt/
test/
tsan/
Darwin/
4 lines

Diff 286877

compiler-rt/test/tsan/Darwin/os_unfair_lock.c

// RUN: %clang_tsan %s -o %t -mmacosx-version-min=10.12 // RUN: %clang_tsan %s -o %t
// RUN: %run %t 2>&1 | FileCheck %s --implicit-check-not='ThreadSanitizer' // RUN: %run %t 2>&1 | FileCheck %s --implicit-check-not='ThreadSanitizer'
// UNSUPPORTED: ios
#include <os/lock.h> #include <os/lock.h>
#include <pthread.h> #include <pthread.h>
#include <stdio.h> #include <stdio.h>
long global_variable; long global_variable;
os_unfair_lock lock = OS_UNFAIR_LOCK_INIT; os_unfair_lock lock = OS_UNFAIR_LOCK_INIT;
void *Thread(void *a) { void *Thread(void *a) {
Show All 17 Lines