Page MenuHomePhabricator

[libTooling] Move RewriteRule include edits to ASTEdit granularity.
ClosedPublic

Authored by ymandel on Aug 11 2020, 7:40 AM.

Details

Summary

Currently, changes to includes are applied to an entire rule. However,
include changes may be specific to particular edits within a rule (for example,
they may apply to one file but not another). Also, include changes may need to
carry metadata, just like other changes. So, we make include changes first-class
edits.

Diff Detail

Event Timeline

ymandel created this revision.Aug 11 2020, 7:40 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 11 2020, 7:40 AM
ymandel requested review of this revision.Aug 11 2020, 7:40 AM
tdl-g accepted this revision.Aug 11 2020, 8:38 AM
This revision is now accepted and ready to land.Aug 11 2020, 8:38 AM
ymandel updated this revision to Diff 284781.Aug 11 2020, 9:18 AM

Updated clang-tidy transformer interpreter correspondingly.

ymandel updated this revision to Diff 284783.Aug 11 2020, 9:20 AM

fixed typo

gribozavr2 accepted this revision.Aug 11 2020, 9:30 AM
gribozavr2 added inline comments.
clang/include/clang/Tooling/Transformer/RewriteRule.h
39
ymandel updated this revision to Diff 284789.Aug 11 2020, 9:35 AM

reword comment per suggestion.

This revision was landed with ongoing or failed builds.Aug 11 2020, 9:48 AM
This revision was automatically updated to reflect the committed changes.
Harbormaster completed remote builds in B67939: Diff 284783.