This is an archive of the discontinued LLVM Phabricator instance.

Differential D85507

[VE] Remove obsoleted getVEAsmModeForCPU function
ClosedPublic

Authored by kaz7 on Aug 7 2020, 1:03 AM.

Details

Reviewers
simoll
k-ishizaka
Commits
rG3ac1eb6358b1: [VE] Remove obsoleted getVEAsmModeForCPU function

Diff Detail

Unit TestsFailed

TimeTest
230 mslinux > Clang Tools.clang-tidy/checkers::misc-redundant-expression.cpp

Event Timeline

kaz7 created this revision.Aug 7 2020, 1:03 AM
Herald added a subscriber: cfe-commits. · View Herald TranscriptAug 7 2020, 1:03 AM
kaz7 requested review of this revision.Aug 7 2020, 1:03 AM
Harbormaster completed remote builds in B67428: Diff 283832.Aug 7 2020, 1:13 AM
simoll accepted this revision.Aug 7 2020, 1:17 AM

Feel free to commit something like this without review

This revision is now accepted and ready to land.Aug 7 2020, 1:17 AM
This revision was landed with ongoing or failed builds.Aug 7 2020, 2:20 AM
Closed by commit rG3ac1eb6358b1: [VE] Remove obsoleted getVEAsmModeForCPU function (authored by kaz7). · Explain Why
This revision was automatically updated to reflect the committed changes.
kaz7 added a commit: rG3ac1eb6358b1: [VE] Remove obsoleted getVEAsmModeForCPU function.

Revision Contents

PathSize
clang/
lib/
Driver/
ToolChains/
Arch/
2 lines
4 lines

Diff 283832

clang/lib/Driver/ToolChains/Arch/VE.h

Show All 16 Lines
namespace clang { namespace clang {
namespace driver { namespace driver {
namespace tools { namespace tools {
namespace ve { namespace ve {
void getVETargetFeatures(const Driver &D, const llvm::opt::ArgList &Args, void getVETargetFeatures(const Driver &D, const llvm::opt::ArgList &Args,
std::vector<llvm::StringRef> &Features); std::vector<llvm::StringRef> &Features);
const char *getVEAsmModeForCPU(llvm::StringRef Name,
const llvm::Triple &Triple);
} // end namespace ve } // end namespace ve
} // namespace tools } // namespace tools
} // end namespace driver } // end namespace driver
} // end namespace clang } // end namespace clang
#endif // LLVM_CLANG_LIB_DRIVER_TOOLCHAINS_ARCH_VE_H #endif // LLVM_CLANG_LIB_DRIVER_TOOLCHAINS_ARCH_VE_H

clang/lib/Driver/ToolChains/Arch/VE.cpp

Show All 12 Lines
#include "llvm/ADT/StringSwitch.h" #include "llvm/ADT/StringSwitch.h"
#include "llvm/Option/ArgList.h" #include "llvm/Option/ArgList.h"
using namespace clang::driver; using namespace clang::driver;
using namespace clang::driver::tools; using namespace clang::driver::tools;
using namespace clang; using namespace clang;
using namespace llvm::opt; using namespace llvm::opt;
const char *ve::getVEAsmModeForCPU(StringRef Name, const llvm::Triple &Triple) {
return "";
}
void ve::getVETargetFeatures(const Driver &D, const ArgList &Args, void ve::getVETargetFeatures(const Driver &D, const ArgList &Args,
std::vector<StringRef> &Features) {} std::vector<StringRef> &Features) {}