Do not generate output in quiet mode, when no modified files exists
Details
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
Quiet mode is very useful for scripting, when only the diff format output is required, or no output if not formatting is needed.
In case of no modified files, git-clang-format will output to screen even though the quiet mode enabled.
This patch changes this behavior, so if quiet flag passes in - no output will be available, even if no modified files exists.
clang/tools/clang-format/git-clang-format | ||
---|---|---|
151–152 | nit: PEP8 recommends opts.verbose >= 0. LGTM otherwise. |
Tried to arc land but don't have the permissions.
From LLVM docs:
It is sufficient to add a comment to the approved review indicating you cannot commit the patch yourself
So here it is, the comment... 😃
@serge-sans-paille - the diff is PEP8 compliant now.
Care to commit, as I don't have the right permissions?
I'll need a contact email to preserve authorship information, can you send me one at sguelton@redhat.com? Thanks!
nit: PEP8 recommends opts.verbose >= 0. LGTM otherwise.