Page MenuHomePhabricator

[libcxx] Add C++20 source_location header
AbandonedPublic

Authored by andreasfertig on Aug 6 2020, 12:19 PM.

Details

Reviewers
mclow.lists
Group Reviewers
Restricted Project
Summary

This patch adds the C++20 header <source_location>.

Diff Detail

Event Timeline

andreasfertig created this revision.Aug 6 2020, 12:19 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 6 2020, 12:20 PM
Herald added a reviewer: Restricted Project. · View Herald Transcript
Herald added a subscriber: mgorny. · View Herald Transcript
andreasfertig requested review of this revision.Aug 6 2020, 12:20 PM

A couple of quick comments, more to come.

libcxx/test/libcxx/support/source_location.pass.cpp
8

This test needs an XFAIL for pre-c++20 tests

10

tests that are not libc++ specific go into test/std, not test/libcxx

Add XFAIL and move test from test/libcxx to test/std.

andreasfertig marked 2 inline comments as done.Aug 6 2020, 11:40 PM

Correct copy&paste left-over in header regex -> source_location.

Please take a look at the discussion in https://reviews.llvm.org/D80376 that has been put on standby because the desired ABI needs compiler support.

Please take a look at the discussion in https://reviews.llvm.org/D80376 that has been put on standby because the desired ABI needs compiler support.

Thanks! I didn't knew that. I looked at your version which comes with even more tests and more feedback. It doesn't make sense to proceed this one here. How can I abandon this?

andreasfertig abandoned this revision.Aug 7 2020, 1:42 AM