Fix Target::Launch in case of synchronous execution

[ki.stfu]

Summary

This patch fixes Target::Launch in case of synchronous execution.

[labath]

Hi,

what is the exact case this patch is trying to fix? Could you give
steps to reproduce? Or even better, a test case?

cheers,
pl

[ki.stfu]

In D8541#145060, @labath wrote:

Hi,

what is the exact case this patch is trying to fix? Could you give
steps to reproduce? Or even better, a test case?

cheers,
pl

Sure. See it in "TEST PLAN" section.

[labath]

wow, that's quite a test plan. :)
Sorry about that, I didn't see anything in the email, and I did not
know that phab does not send out the test plans O:)

pl

[ki.stfu]

In D8541#145077, @labath wrote:

Sorry about that, I didn't see anything in the email, and I did not
know that phab does not send out the test plans O:)

It's a surprise for me too :)

[clayborg]

Looks good.

source/Target/Target.cpp

Target::Launch (ProcessLaunchInfo &launch_info, Stream *stream)
     {
         if (error.Success())
             error.SetErrorString("failed to launch or debug process");
         return error;
     }
 
     if (error.Success())
     {
-        if (launch_info.GetFlags().Test(eLaunchFlagStopAtEntry) == false)
+        if (synchronous_execution || launch_info.GetFlags().Test(eLaunchFlagStopAtEntry) == false)
         {
+            EventSP event_sp;
             ListenerSP hijack_listener_sp (launch_info.GetHijackListener());
 
-            StateType state = m_process_sp->WaitForProcessToStop (NULL, NULL, false, hijack_listener_sp.get(), NULL);
+            StateType state = m_process_sp->WaitForProcessToStop (NULL, &event_sp, false, hijack_listener_sp.get(), NULL);
             
             if (state == eStateStopped)
             {
+                if (launch_info.GetFlags().Test(eLaunchFlagStopAtEntry) == false)
+                {
                     if (!synchronous_execution)
                         m_process_sp->RestoreProcessEvents ();
 
                     error = m_process_sp->PrivateResume();
 
                     if (error.Success())
                     {
                         // there is a race condition where this thread will return up the call stack to the main command
                         // handler and show an (lldb) prompt before HandlePrivateEvent (from PrivateStateThread) has
                         // a chance to call PushProcessIOHandler()
                         m_process_sp->SyncIOHandler(2000);
 
                         if (synchronous_execution)
                         {
                             state = m_process_sp->WaitForProcessToStop (NULL, NULL, true, hijack_listener_sp.get(), stream);
                             const bool must_be_alive = false; // eStateExited is ok, so this must be false
                             if (!StateIsStoppedState(state, must_be_alive))
                             {
                                 error.SetErrorStringWithFormat("process isn't stopped: %s", StateAsCString(state));
                             }
                         }
                     }
                     else
                     {
                         Error error2;
                         error2.SetErrorStringWithFormat("process resume at entry point failed: %s", error.AsCString());
                         error = error2;
                     }
                 }
+                else
+                {
+                    assert(synchronous_execution && launch_info.GetFlags().Test(eLaunchFlagStopAtEntry) == true);
+
+                    // Target was stopped at entry as was intended. Need to notify the listeners about it.
+                    m_process_sp->RestoreProcessEvents();
+                    m_process_sp->HandlePrivateEvent(event_sp);
+
+                    // there is a race condition where this thread will return up the call stack to the main command
+                    // handler and show an (lldb) prompt before HandlePrivateEvent (from PrivateStateThread) has
+                    // a chance to call PushProcessIOHandler()
+                    m_process_sp->SyncIOHandler(2000);
+                }
+            }
             else if (state == eStateExited)
             {
                 bool with_shell = !!launch_info.GetShell();
                 const int exit_status = m_process_sp->GetExitStatus();
                 const char *exit_desc = m_process_sp->GetExitDescription();
 #define LAUNCH_SHELL_MESSAGE "\n'r' and 'run' are aliases that default to launching through a shell.\nTry launching without going through a shell by using 'process launch'."
                 if (exit_desc && exit_desc[0])
                 {