Page MenuHomePhabricator

[msan] Remove readnone and friends from call sites.
ClosedPublic

Authored by eugenis on Aug 4 2020, 4:50 PM.

Details

Summary

MSan removes readnone/readonly and similar attributes from callees,
because after MSan instrumentation those attributes no longer apply.

This change removes the attributes from call sites, as well.

Failing to do this may cause DSE of paramTLS stores before calls to
readonly/readnone functions.

Diff Detail

Event Timeline

eugenis created this revision.Aug 4 2020, 4:50 PM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added a subscriber: hiraditya. · View Herald Transcript
eugenis requested review of this revision.Aug 4 2020, 4:50 PM
guiand accepted this revision.Aug 4 2020, 5:11 PM

LGTM

This revision is now accepted and ready to land.Aug 4 2020, 5:11 PM
This revision was landed with ongoing or failed builds.Aug 5 2020, 10:41 AM
This revision was automatically updated to reflect the committed changes.