This is an archive of the discontinued LLVM Phabricator instance.

[UBSan] Increase robustness of tests
ClosedPublic

Authored by yln on Aug 3 2020, 1:28 PM.

Details

Summary

These UBSan tests assert the absence of runtime errors via count 0,
which means "expect no output". This fails the test unnecessarily in
some environments (e.g., iOS simulator in our case). Alter the test to
be a bit more specific and "expect no error" instead of "expect no
output".

rdar://65503408

Diff Detail

Event Timeline

yln created this revision.Aug 3 2020, 1:28 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 3 2020, 1:28 PM
Herald added a subscriber: Restricted Project. · View Herald Transcript
yln requested review of this revision.Aug 3 2020, 1:28 PM
This revision was not accepted when it landed; it landed in state Needs Review.Aug 3 2020, 3:27 PM
This revision was automatically updated to reflect the committed changes.
vsk added a comment.Aug 4 2020, 8:21 AM

Thanks for fixing this!