Page MenuHomePhabricator

[msan] Respect no_huge_pages_for_shadow.
ClosedPublic

Authored by eugenis on Fri, Jul 31, 5:20 PM.

Details

Summary

Disable huge pages in the MSan shadow region when
no_huge_pages_for_shadow == true (default).

Diff Detail

Event Timeline

eugenis created this revision.Fri, Jul 31, 5:20 PM
Herald added a project: Restricted Project. · View Herald TranscriptFri, Jul 31, 5:20 PM
Herald added a subscriber: Restricted Project. · View Herald Transcript
eugenis requested review of this revision.Fri, Jul 31, 5:20 PM
MaskRay accepted this revision.Fri, Jul 31, 5:25 PM
MaskRay added a subscriber: MaskRay.

LGTM.

This revision is now accepted and ready to land.Fri, Jul 31, 5:25 PM

Is there any way testing this?

Testing this would be pretty hard - we'd need to touch a bunch of memory pages, and then somehow wait for the huge page daemon to merge them (or not).

ckennelly accepted this revision.Fri, Jul 31, 7:03 PM
ckennelly added a subscriber: ckennelly.

We could scan /proc/self/smaps for regions huge page eligibility, but that's probably brittle/annoying.

vitalybuka accepted this revision.Sat, Aug 1, 12:49 AM
This revision was automatically updated to reflect the committed changes.