This is an archive of the discontinued LLVM Phabricator instance.

Paths

Table of Contentst

-
libunwind/test/
-
test/
-
CMakeLists.txt

Differential D85004

[libunwind] Make the test depend on the libunwind explicitly.
ClosedPublic

Authored by danielkiss on Jul 30 2020, 11:36 PM.

Download Raw Diff

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rG9c3f6fb68807: [libunwind] Make the test depend on the libunwind explicitly.

Summary

Before this patch the ninja check-unwind won't rebuild the unwind library.

Diff Detail

Repository: rG LLVM Github Monorepo

Event Timeline

danielkiss created this revision.Jul 30 2020, 11:36 PM

Herald added a subscriber: mgorny. · View Herald TranscriptJul 30 2020, 11:36 PM

danielkiss requested review of this revision.Jul 30 2020, 11:36 PM

LGTM, thank you!

This revision is now accepted and ready to land.Jul 31 2020, 7:55 AM

Mind doing the same thing for libcxxabi? I think it has the same problem.

Thanks.
Cmake file of libcxxabi seems fine to me, it just needs -DLIBCXXABI_USE_LLVM_UNWINDER=YES.

Isn't it missing DEPENDS cxxabi the same way this was missing DEPENDS unwind?

https://github.com/llvm/llvm-project/blob/19bc9ea480b60b607a3e303f20c7a3a2ea553369/libcxxabi/test/CMakeLists.txt#L81

Added here as I see:
https://github.com/llvm/llvm-project/blob/19bc9ea480b60b607a3e303f20c7a3a2ea553369/libcxxabi/test/CMakeLists.txt#L57

Closed by commit rG9c3f6fb68807: [libunwind] Make the test depend on the libunwind explicitly. (authored by danielkiss). · Explain WhyAug 3 2020, 12:46 AM

This revision was automatically updated to reflect the committed changes.

danielkiss added a commit: rG9c3f6fb68807: [libunwind] Make the test depend on the libunwind explicitly..

Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptAug 3 2020, 12:46 AM

Herald added a reviewer: Restricted Project. · View Herald Transcript

Herald added subscribers: libcxx-commits, llvm-commits. · View Herald Transcript

In D85004#2188062, @danielkiss wrote:

Added here as I see:
https://github.com/llvm/llvm-project/blob/19bc9ea480b60b607a3e303f20c7a3a2ea553369/libcxxabi/test/CMakeLists.txt#L57

oh, you're right. thanks!

Revision Contents

Path

Size

libunwind/

test/

2 lines

Diff 282515

libunwind/test/CMakeLists.txt

	Show All 26 Lines
	set(AUTO_GEN_COMMENT "## Autogenerated by libunwind configuration.\n# Do not edit!")			set(AUTO_GEN_COMMENT "## Autogenerated by libunwind configuration.\n# Do not edit!")
	configure_lit_site_cfg(			configure_lit_site_cfg(
	"${LIBUNWIND_TEST_CONFIG}"			"${LIBUNWIND_TEST_CONFIG}"
	${CMAKE_CURRENT_BINARY_DIR}/lit.site.cfg			${CMAKE_CURRENT_BINARY_DIR}/lit.site.cfg
	MAIN_CONFIG "${CMAKE_CURRENT_SOURCE_DIR}/lit.cfg.py")			MAIN_CONFIG "${CMAKE_CURRENT_SOURCE_DIR}/lit.cfg.py")

	add_lit_testsuite(check-unwind "Running libunwind tests"			add_lit_testsuite(check-unwind "Running libunwind tests"
	${CMAKE_CURRENT_BINARY_DIR}			${CMAKE_CURRENT_BINARY_DIR}
	DEPENDS ${LIBUNWIND_TEST_DEPS})			DEPENDS unwind ${LIBUNWIND_TEST_DEPS})