This is an archive of the discontinued LLVM Phabricator instance.

Remove Olesen from LLVM code owners
ClosedPublic

Authored by Paul-C-Anagnostopoulos on Jul 30 2020, 10:57 AM.

Details

Summary

I contacted Jakob Olesen about TableGen and he replied that he is no longer involved with the project.

Diff Detail

Event Timeline

Herald added a project: Restricted Project. · View Herald TranscriptJul 30 2020, 10:57 AM
Paul-C-Anagnostopoulos requested review of this revision.Jul 30 2020, 10:57 AM

Sounds reasonable - looks like Jokob's been out of the community for a couple of years now.

Please remove the whole entry - we don't really have entries for "unassigned" things - everything's community owned (or, ultimately, Chris Lattner is the decider/tie breaker) unless it's got a specific owner.

I have removed the entire entry for TableGen.

dblaikie accepted this revision.Aug 3 2020, 1:37 PM

Looks good - thanks!

This revision is now accepted and ready to land.Aug 3 2020, 1:37 PM

Is there anything left that I have to do?

Is there anything left that I have to do?

If you don't have commit access to the project, you can ask someone else to commit it for you. (sorry, that usually ends up being a manual step after the patch is approved - since we don't all keep in mind/remember who's got commit access and who doesn't) If you do have commit access - you can go ahead and commit/push the patch.

I'm such a newbie that I barely know what commit access is. When I saw "This revision is now accepted and ready to land." above, I assumed it meant that you had committed this patch. So, I have one question and one favor to ask.

  1. What does "ready to land" mean?
  1. Could you commit this for me?
This revision was automatically updated to reflect the committed changes.

I'm such a newbie that I barely know what commit access is. When I saw "This revision is now accepted and ready to land." above, I assumed it meant that you had committed this patch. So, I have one question and one favor to ask.

  1. What does "ready to land" mean?

Means someone (hopefully with the authority to make this call) thinks the patch is suitable for LLVM in its current state. (ie: review has concluded)

  1. Could you commit this for me?

Sure thing - done!

Sure thing!

More details on the review/contribution process can be found here: https://llvm.org/docs/Contributing.html

Specifically: "This cycle continues until all requests and comments have been addressed and a reviewer accepts the patch with a Looks good to me or LGTM. Once that is done the change can be committed. If you do not have commit access, please let people know during the review and someone should commit it on your behalf."