This is an archive of the discontinued LLVM Phabricator instance.

[clang] Fix ConceptSpecializationExpr::getEndLoc()
ClosedPublic

Authored by nridge on Jul 26 2020, 7:50 PM.

Details

Summary

It returned an invalid location in case of a constrained-parameter
with no explicit arguments.

Diff Detail

Event Timeline

nridge created this revision.Jul 26 2020, 7:50 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 26 2020, 7:50 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript

Spun off from D84136. Depends on D84461.

hokein added inline comments.Jul 27 2020, 3:17 AM
clang/test/AST/ast-dump-concepts.cpp
14

could you also verify what's the end loc for this case?

nridge updated this revision to Diff 281123.Jul 27 2020, 11:45 PM

Address review comment

nridge marked an inline comment as done.Jul 27 2020, 11:46 PM
hokein accepted this revision.Jul 28 2020, 3:10 AM
This revision is now accepted and ready to land.Jul 28 2020, 3:10 AM
This revision was landed with ongoing or failed builds.Jul 29 2020, 4:05 AM
This revision was automatically updated to reflect the committed changes.