This is an archive of the discontinued LLVM Phabricator instance.

Differential D84434

[libFuzzer] Disable interceptor tests on non-Linux platforms.
ClosedPublic

Authored by dokyungs on Jul 23 2020, 9:36 AM.

Details

Reviewers
morehouse
hctim
Commits
rG769dab207e8b: [libFuzzer] Disable interceptor tests on non-Linux platforms.
Summary

libFuzzer's interceptor support added in 831ae45e3dc609e43ba561af07670a8fe47461ef currently only works on Linux. This patch disables the test cases added as part of that commit on non-Linux platforms.

Diff Detail

Event Timeline

dokyungs created this revision.Jul 23 2020, 9:36 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 23 2020, 9:36 AM
Herald added a subscriber: Restricted Project. · View Herald Transcript
dokyungs added a comment.Jul 23 2020, 9:45 AM

I just realized that NoAsan(Memcmp/Strcmp/Strncmp/Strstr) tests also need disabling, since interceptors right now are only effective on LINUX. I will follow up with an updated patch.

dokyungs updated this revision to Diff 280193.Jul 23 2020, 10:10 AM

Disable all interceptor test cases on non-Linux platforms, since libFuzzer's interceptor support is enabled only on Linux.

dokyungs retitled this revision from [libFuzzer] Disable custom allocator test on Windows. to [libFuzzer] Disable interceptor tests on non-Linux platforms..Jul 23 2020, 10:10 AM
dokyungs edited the summary of this revision. (Show Details)
morehouse accepted this revision.Jul 23 2020, 10:17 AM

LGTM

This revision is now accepted and ready to land.Jul 23 2020, 10:17 AM
Closed by commit rG769dab207e8b: [libFuzzer] Disable interceptor tests on non-Linux platforms. (authored by dokyungs). · Explain WhyJul 23 2020, 10:23 AM
This revision was automatically updated to reflect the committed changes.
Harbormaster completed remote builds in B65409: Diff 280177.Jul 23 2020, 10:45 AM
Harbormaster completed remote builds in B65422: Diff 280193.Jul 23 2020, 11:05 AM

Revision Contents

PathSize
compiler-rt/
test/
fuzzer/
26 lines
3 lines
3 lines
3 lines
3 lines

Diff 280177

compiler-rt/test/fuzzer/custom-allocator.test

UNSUPPORTED: freebsd UNSUPPORTED: freebsd, windows
RUN: %cpp_compiler -fno-sanitize=address -fno-builtin %S/CustomAllocator.cpp %S/EmptyTest.cpp -o %t-NoAsanCustomAllocatorTest RUN: %cpp_compiler -fno-sanitize=address -fno-builtin %S/CustomAllocator.cpp %S/EmptyTest.cpp -o %t-NoAsanCustomAllocatorTest
RUN: %run %t-NoAsanCustomAllocatorTest -runs=1 2>&1 | FileCheck %s RUN: %run %t-NoAsanCustomAllocatorTest -runs=1 2>&1 | FileCheck %s --check-prefix=CHECK1
CHECK: CALLOC-MEMCMP CHECK1: CALLOC-MEMCMP
CHECK-NEXT: CALLOC-STRNCMP CHECK1-NEXT: CALLOC-STRNCMP
CHECK-NEXT: CALLOC-STRCMP CHECK1-NEXT: CALLOC-STRCMP
CHECK-NEXT: CALLOC-STRSTR CHECK1-NEXT: CALLOC-STRSTR
RUN: %cpp_compiler -fno-sanitize=address -fno-builtin-calloc -fno-builtin-memcmp %S/CustomAllocator.cpp %S/MemcmpTest.cpp -o %t-NoAsanCustomAllocatorMemcmpTest
RUN: not %run %t-NoAsanCustomAllocatorMemcmpTest -seed=1 -runs=10000000 2>&1 | FileCheck %s
RUN: %cpp_compiler -fno-sanitize=address -fno-builtin-calloc -fno-builtin-strcmp %S/CustomAllocator.cpp %S/StrcmpTest.cpp -o %t-NoAsanCustomAllocatorStrcmpTest
RUN: not %run %t-NoAsanCustomAllocatorStrcmpTest -seed=1 -runs=2000000 2>&1 | FileCheck %s
RUN: %cpp_compiler -fno-sanitize=address -fno-builtin-calloc -fno-builtin-strncmp %S/CustomAllocator.cpp %S/StrncmpTest.cpp -o %t-NoAsanCustomAllocatorStrncmpTest
RUN: not %run %t-NoAsanCustomAllocatorStrncmpTest -seed=2 -runs=10000000 2>&1 | FileCheck %s
RUN: %cpp_compiler -fno-sanitize=address -fno-builtin-calloc -fno-builtin-strstr %S/CustomAllocator.cpp %S/StrstrTest.cpp -o %t-NoAsanCustomAllocatorStrstrTest
RUN: not %run %t-NoAsanCustomAllocatorStrstrTest -seed=1 -runs=2000000 2>&1 | FileCheck %s
CHECK: BINGO

compiler-rt/test/fuzzer/memcmp.test

UNSUPPORTED: freebsd UNSUPPORTED: freebsd
RUN: %cpp_compiler %S/MemcmpTest.cpp -o %t-MemcmpTest RUN: %cpp_compiler %S/MemcmpTest.cpp -o %t-MemcmpTest
RUN: not %run %t-MemcmpTest -seed=1 -runs=10000000 2>&1 | FileCheck %s RUN: not %run %t-MemcmpTest -seed=1 -runs=10000000 2>&1 | FileCheck %s
RUN: %cpp_compiler -fno-sanitize=address -fno-builtin-memcmp %S/MemcmpTest.cpp -o %t-NoAsanMemcmpTest RUN: %cpp_compiler -fno-sanitize=address -fno-builtin-memcmp %S/MemcmpTest.cpp -o %t-NoAsanMemcmpTest
RUN: not %run %t-NoAsanMemcmpTest -seed=1 -runs=10000000 2>&1 | FileCheck %s RUN: not %run %t-NoAsanMemcmpTest -seed=1 -runs=10000000 2>&1 | FileCheck %s
RUN: %cpp_compiler -fno-sanitize=address -fno-builtin-calloc -fno-builtin-memcmp %S/CustomAllocator.cpp %S/MemcmpTest.cpp -o %t-NoAsanCustomAllocatorMemcmpTest
RUN: not %run %t-NoAsanCustomAllocatorMemcmpTest -seed=1 -runs=10000000 2>&1 | FileCheck %s
CHECK: BINGO CHECK: BINGO

compiler-rt/test/fuzzer/strcmp.test

UNSUPPORTED: freebsd UNSUPPORTED: freebsd
RUN: %cpp_compiler %S/StrcmpTest.cpp -o %t-StrcmpTest RUN: %cpp_compiler %S/StrcmpTest.cpp -o %t-StrcmpTest
RUN: not %run %t-StrcmpTest -seed=1 -runs=2000000 2>&1 | FileCheck %s RUN: not %run %t-StrcmpTest -seed=1 -runs=2000000 2>&1 | FileCheck %s
RUN: %cpp_compiler -fno-sanitize=address -fno-builtin-strcmp %S/StrcmpTest.cpp -o %t-NoAsanStrcmpTest RUN: %cpp_compiler -fno-sanitize=address -fno-builtin-strcmp %S/StrcmpTest.cpp -o %t-NoAsanStrcmpTest
RUN: not %run %t-NoAsanStrcmpTest -seed=1 -runs=2000000 2>&1 | FileCheck %s RUN: not %run %t-NoAsanStrcmpTest -seed=1 -runs=2000000 2>&1 | FileCheck %s
RUN: %cpp_compiler -fno-sanitize=address -fno-builtin-calloc -fno-builtin-strcmp %S/CustomAllocator.cpp %S/StrcmpTest.cpp -o %t-NoAsanCustomAllocatorStrcmpTest
RUN: not %run %t-NoAsanCustomAllocatorStrcmpTest -seed=1 -runs=2000000 2>&1 | FileCheck %s
CHECK: BINGO CHECK: BINGO

compiler-rt/test/fuzzer/strncmp.test

UNSUPPORTED: freebsd UNSUPPORTED: freebsd
RUN: %cpp_compiler %S/StrncmpTest.cpp -o %t-StrncmpTest RUN: %cpp_compiler %S/StrncmpTest.cpp -o %t-StrncmpTest
RUN: not %run %t-StrncmpTest -seed=2 -runs=10000000 2>&1 | FileCheck %s RUN: not %run %t-StrncmpTest -seed=2 -runs=10000000 2>&1 | FileCheck %s
RUN: %cpp_compiler -fno-sanitize=address -fno-builtin-strncmp %S/StrncmpTest.cpp -o %t-NoAsanStrncmpTest RUN: %cpp_compiler -fno-sanitize=address -fno-builtin-strncmp %S/StrncmpTest.cpp -o %t-NoAsanStrncmpTest
RUN: not %run %t-NoAsanStrncmpTest -seed=2 -runs=10000000 2>&1 | FileCheck %s RUN: not %run %t-NoAsanStrncmpTest -seed=2 -runs=10000000 2>&1 | FileCheck %s
RUN: %cpp_compiler -fno-sanitize=address -fno-builtin-calloc -fno-builtin-strncmp %S/CustomAllocator.cpp %S/StrncmpTest.cpp -o %t-NoAsanCustomAllocatorStrncmpTest
RUN: not %run %t-NoAsanCustomAllocatorStrncmpTest -seed=2 -runs=10000000 2>&1 | FileCheck %s
CHECK: BINGO CHECK: BINGO

compiler-rt/test/fuzzer/strstr.test

UNSUPPORTED: freebsd UNSUPPORTED: freebsd
RUN: %cpp_compiler %S/StrstrTest.cpp -o %t-StrstrTest RUN: %cpp_compiler %S/StrstrTest.cpp -o %t-StrstrTest
RUN: not %run %t-StrstrTest -seed=1 -runs=2000000 2>&1 | FileCheck %s RUN: not %run %t-StrstrTest -seed=1 -runs=2000000 2>&1 | FileCheck %s
RUN: %cpp_compiler -fno-sanitize=address -fno-builtin-strstr %S/StrstrTest.cpp -o %t-NoAsanStrstrTest RUN: %cpp_compiler -fno-sanitize=address -fno-builtin-strstr %S/StrstrTest.cpp -o %t-NoAsanStrstrTest
RUN: not %run %t-NoAsanStrstrTest -seed=1 -runs=2000000 2>&1 | FileCheck %s RUN: not %run %t-NoAsanStrstrTest -seed=1 -runs=2000000 2>&1 | FileCheck %s
RUN: %cpp_compiler -fno-sanitize=address -fno-builtin-calloc -fno-builtin-strstr %S/CustomAllocator.cpp %S/StrstrTest.cpp -o %t-NoAsanCustomAllocatorStrstrTest
RUN: not %run %t-NoAsanCustomAllocatorStrstrTest -seed=1 -runs=2000000 2>&1 | FileCheck %s
CHECK: BINGO CHECK: BINGO