Page MenuHomePhabricator

DebugInfo: Use debug_line.dwo for debug_macro.dwo
ClosedPublic

Authored by dblaikie on Jul 21 2020, 4:44 PM.

Details

Summary

This is an alternative proposal to D81476 (and D82084) - the details were sufficiently confusing to me it seemed easier to write some code and see how it looks.

Diff Detail

Event Timeline

dblaikie created this revision.Jul 21 2020, 4:44 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 21 2020, 4:44 PM
SouraVX accepted this revision.Jul 22 2020, 6:27 AM

Thank you so much @dblaikie for this. Admittedly, for all the direction I've been digging, missed this one :)
The catch here is that getDwoLineTable(U)->getFile(... this will enable the line table through MCDwarf interface, so we don't have/need to rely in DwarfTypeUnit interface for enabling line table.
Anyways, I'm planning to abandon all the revisions associated with this. IMHO D82084 is also not needed(since you did it without touching that) so we can leave it until there is actual need/situation ?

A side note: Do you also plan to put this in LLVM11 branch. AFAIK -gdwarf-5 -gsplit-dwarf -fdebug-macro still produces same error(Relocation in DWO object). This patch solves that.

This revision is now accepted and ready to land.Jul 22 2020, 6:27 AM
This revision was automatically updated to reflect the committed changes.