This is an archive of the discontinued LLVM Phabricator instance.

[libcxx][lit] Add support for custom ssh/scp flags in ssh.py
ClosedPublic

Authored by arichardson on Jul 18 2020, 5:53 AM.

Details

Summary

In our CHERI Jenkins CI we need to pass -F <custom_config_file> to each
ssh/scp command to set various arguments such as the localhost port, usage
of controlmaster, etc. to speed up connections to our emulated QEMU systems.

For our specific use-case I could have also added a single --ssh-config-file
argument that can be used for both the scp and ssh commands, but being able
to pass arbitrary extra flags for both commands seems more flexible.

Diff Detail

Event Timeline

arichardson created this revision.Jul 18 2020, 5:53 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 18 2020, 5:53 AM
Herald added 1 blocking reviewer(s): Restricted Project. · View Herald Transcript
ldionne accepted this revision.Sep 14 2020, 11:51 AM
This revision is now accepted and ready to land.Sep 14 2020, 11:51 AM

LGTM, but based on D84421, do you actually need the extra scp args?

LGTM, but based on D84421, do you actually need the extra scp args?

Unfortunately, in some configuration variants we can't use shared mounts since they are (currently) unreliable.

This revision was landed with ongoing or failed builds.Oct 6 2020, 3:40 AM
This revision was automatically updated to reflect the committed changes.