This is an archive of the discontinued LLVM Phabricator instance.

Explicitly use utf-8 in send_string
ClosedPublic

Authored by trixirt on Jul 16 2020, 1:42 PM.

Details

Summary

send_patched_file decodes with utf-8.
The default encoder for python 2 is ascii.

So it is necessary to also change send_string to use utf-8.

Diff Detail

Event Timeline

trixirt created this revision.Jul 16 2020, 1:42 PM

According to the doc, 'utf-8' is already the default encoding, at least on py3, but not on py2. i guess that the problem you're trying to fix?

Yes, this break on py2, and py3 the change is a noop

LGTM then :-)

This revision is now accepted and ready to land.Aug 31 2020, 11:10 PM
This revision was landed with ongoing or failed builds.Sep 7 2020, 12:31 AM
This revision was automatically updated to reflect the committed changes.

Commited on your behalf using what I expect to be your official email address :-)