This is an archive of the discontinued LLVM Phabricator instance.

Corrected __libfuzzer_is_present symbol inclusion for MSVC x86 32-bit
ClosedPublic

Authored by jagunter on Jul 10 2020, 4:02 PM.

Reviewers

metzman
vitalybuka

Commits

Summary

The incorrect symbol will cause linking failures for 32-bit targets:

clang_rt.fuzzer-i386.lib(FuzzerDriver.obj) : error LNK2001: unresolved external symbol __libfuzzer_is_present

Verified no longer fails to link with this change for 32-bit and still succeeds for 64-bit MSVC.

Herald added a subscriber: Restricted Project. · View Herald Transcript

jagunter added a subscriber: llvm-commits.

This change LGTM.
I'll let @vitalybuka decide if he wants to accept.

This revision is now accepted and ready to land.Jul 14 2020, 1:07 AM

Ah sorry should've mentioned earlier I don't have commit access, so if someone can commit on my behalf that'd be great.

This revision was automatically updated to reflect the committed changes.

Path

Size

compiler-rt/

lib/

fuzzer/

4 lines

	Show All 27 Lines
	#include <string>			#include <string>
	#include <thread>			#include <thread>
	#include <fstream>			#include <fstream>

	// This function should be present in the libFuzzer so that the client			// This function should be present in the libFuzzer so that the client
	// binary can test for its existence.			// binary can test for its existence.
	#if LIBFUZZER_MSVC			#if LIBFUZZER_MSVC
	extern "C" void __libfuzzer_is_present() {}			extern "C" void __libfuzzer_is_present() {}
				#if defined(_M_IX86) \|\| defined(__i386__)
				#pragma comment(linker, "/include:___libfuzzer_is_present")
				#else
	#pragma comment(linker, "/include:__libfuzzer_is_present")			#pragma comment(linker, "/include:__libfuzzer_is_present")
				#endif
	#else			#else
	extern "C" __attribute__((used)) void __libfuzzer_is_present() {}			extern "C" __attribute__((used)) void __libfuzzer_is_present() {}
	#endif // LIBFUZZER_MSVC			#endif // LIBFUZZER_MSVC

	namespace fuzzer {			namespace fuzzer {

	// Program arguments.			// Program arguments.
	struct FlagDescription {			struct FlagDescription {
	▲ Show 20 Lines • Show All 816 Lines • Show Last 20 Lines