HomePhabricator

[NewPM][ASan] Make ASan tests work under NPM

Authored by aeubanks on Jul 17 2020, 5:49 PM.

Description

[NewPM][ASan] Make ASan tests work under NPM

Under NPM, the asan-globals-md analysis is required but cannot be run
within the asan function pass due to module analyses not being able to
run from a function pass. So this pins all tests using "-asan" to the
legacy PM and adds a corresponding RUN line with
-passes='require<asan-globals-md>,function(asan)'.

Now all tests in Instrumentation/AddressSanitizer pass when
-enable-new-pm is by default on.

Tests were automatically converted using the following python script and
failures were manually fixed up.

import sys
for i in sys.argv:

with open(i, 'r') as f:
    s = f.read()
with open(i, 'w') as f:
    for l in s.splitlines():
        if "RUN:" in l and ' -asan -asan-module ' in l and '\\' not in l:
            f.write(l.replace(' -asan -asan-module ', ' -asan -asan-module -enable-new-pm=0 '))
            f.write('\n')
            f.write(l.replace(' -asan -asan-module ', " -passes='require<asan-globals-md>,function(asan),module(asan-module)' "))
            f.write('\n')
        elif "RUN:" in l and ' -asan ' in l and '\\' not in l:
            f.write(l.replace(' -asan ', ' -asan -enable-new-pm=0 '))
            f.write('\n')
            f.write(l.replace(' -asan ', " -passes='require<asan-globals-md>,function(asan)' "))
            f.write('\n')
        else:
            f.write(l)
            f.write('\n')

See https://bugs.llvm.org/show_bug.cgi?id=46611.

Reviewed By: vitalybuka

Differential Revision: https://reviews.llvm.org/D83921

Details