[libc][benchmark] Add display option to render.py3

[avieira]

Summary

Whilst looking at the LLVM libc benchmarks I found the need to display the ‘sizes’ of the datasets against ‘bytes/cycle’ rather than ‘time’. For this reason I added an option called ‘—display’ to enable to switch between the different modes. This was just for some local tests, but I thought it might be useful to others upstream.

[gchatelet]

libc/benchmarks/render.py3

135

Python being what it is would you mind hoisting root["Host"]["CpuFrequency"] out of the for loops?

[avieira]

Hoisted frequency out of invariant loops.

[gchatelet]

Thanks for the contribution @avieira : )

libc/benchmarks/render.py3

def get_configuration(jsons):
     for root in jsons:
         if config and config != root["Configuration"]:
             return None
         if not config:
             config = root["Configuration"]
     return config
 
 
-def setup_graphs(files):
+def setup_graphs(files, display):
     """Setups the graphs to render from the json files."""
     jsons = []
     for file in files:
         with open(file) as json_file:
             jsons.append(json.load(json_file))
     if not jsons:
         sys.exit("Nothing to process")
 
     for root in jsons:
+        frequency = root["Host"]["CpuFrequency"]
         for function in root["Functions"]:
             function_name = function["Name"]
             sizes = function["Sizes"]
             runtimes = function["Runtimes"]
             assert len(sizes) == len(runtimes)
             values = collections.defaultdict(lambda: [])
             for i in range(len(sizes)):
-              values[sizes[i]].append(runtimes[i])
+              value = runtimes[i]
+              if display == "cycles":
+                  value = value * frequency
+              if display == "bytespercycle":
+                  value = value * frequency
+                  value = sizes[i] / value
+              values[sizes[i]].append(value)
             add_plot(function_name, values)
 
     config = get_configuration(jsons)
     if config:
         plt.figtext(
             0.95,
             0.15,
             pprint.pformat(config),
             verticalalignment="bottom",
             horizontalalignment="right",
             multialignment="left",
             fontsize="small",
             bbox=dict(boxstyle="round", facecolor="wheat"))
 
     axes = plt.gca()
     axes.set_title(get_title(get_host(jsons)))
     axes.set_ylim(bottom=0)
     axes.set_xlabel("Size")
-    axes.set_ylabel("Time")
     axes.xaxis.set_major_formatter(EngFormatter(unit="B"))
+    if display == "cycles":
+          axes.set_ylabel("Cycles")
+    if display == "time":
+          axes.set_ylabel("Time")
           axes.yaxis.set_major_formatter(EngFormatter(unit="s"))
+    if display == "bytespercycle":
+          axes.set_ylabel("bytes/cycle")
+
     plt.legend()
     plt.grid()
 
 
 def main():
     parser = argparse.ArgumentParser(
         description="Process benchmark json files.")
     parser.add_argument("files", nargs="+", help="The json files to read from.")
     parser.add_argument("--output", help="The output file to write the graph.")
     parser.add_argument(
         "--headless",
         help="If set do not display the graph.",
         action="store_true")
+    parser.add_argument(
+        "--display",
+        choices= ["time", "cycles", "bytespercycle"],
+        default="time",
+        help="Use to display either 'time', 'cycles' or 'bytes/cycle'.")
+
     args = parser.parse_args()
-    setup_graphs(args.files)
+    setup_graphs(args.files, args.display)
     if args.output:
         plt.savefig(args.output)
     if not args.headless:
         plt.show()
 
 if __name__ == "__main__":
     main()