This is an archive of the discontinued LLVM Phabricator instance.

[llvm] [docs] Do not require recommonmark for manpage build
ClosedPublic

Authored by mgorny on Jul 4 2020, 10:32 AM.

Details

Summary

Do not enforce recommonmark dependency if sphinx is called to build
manpages. In order to do this, try to import recommonmark first
and do not configure it if it's not available. Additionally, declare
a custom tags for the selected builder via CMake, and ignore
recommonmark import failure when 'man' target is used.

This will permit us to avoid the problematic recommonmark dependency
for the majority of Gentoo users that do not need to locally build
the complete documentation but want to have tool manpages.

Diff Detail

Event Timeline

mgorny created this revision.Jul 4 2020, 10:32 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 4 2020, 10:32 AM

(though personally I'd prefer just converting these three docs into .rst and having a single markup everywhere, without extra dependencies)

JDevlieghere accepted this revision.Jul 7 2020, 10:18 AM

I think this makes sense, I often need to build just the man pages and if we can avoid the dependency I'm all for it. LGTM.

(though personally I'd prefer just converting these three docs into .rst and having a single markup everywhere, without extra dependencies)

Personally I agree, but it seems LLVM might be moving in the opposite direction.

This revision is now accepted and ready to land.Jul 7 2020, 10:18 AM
This revision was automatically updated to reflect the committed changes.