This is an archive of the discontinued LLVM Phabricator instance.

Differential D82902

Propogate GenCrashDiag in report_fatal_error
Needs ReviewPublic

Authored by jpienaar on Jun 30 2020, 11:57 AM.

Details

Reviewers
lhames
Summary

This GenCrashDiag value is unused and seems to need to gets propagated here.

Diff Detail

Unit TestsFailed

TimeTest
9,780 mslinux > libomp.env::Unknown Unit Message ("")
1,790 mslinux > libomp.worksharing/for::Unknown Unit Message ("")

Event Timeline

jpienaar created this revision.Jun 30 2020, 11:57 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 30 2020, 11:57 AM
Herald added subscribers: llvm-commits, hiraditya. · View Herald Transcript
Harbormaster failed remote builds in B62379: Diff 274564!Jun 30 2020, 1:04 PM

Revision Contents

PathSize
llvm/
lib/
Support/
2 lines

Diff 274564

llvm/lib/Support/Error.cpp

Show First 20 Lines • Show All 138 Lines • ▼ Show 20 Lines
void report_fatal_error(Error Err, bool GenCrashDiag) { void report_fatal_error(Error Err, bool GenCrashDiag) {
assert(Err && "report_fatal_error called with success value"); assert(Err && "report_fatal_error called with success value");
std::string ErrMsg; std::string ErrMsg;
{ {
raw_string_ostream ErrStream(ErrMsg); raw_string_ostream ErrStream(ErrMsg);
logAllUnhandledErrors(std::move(Err), ErrStream); logAllUnhandledErrors(std::move(Err), ErrStream);
} }
report_fatal_error(ErrMsg); report_fatal_error(ErrMsg, GenCrashDiag);
} }
} // end namespace llvm } // end namespace llvm
LLVMErrorTypeId LLVMGetErrorTypeId(LLVMErrorRef Err) { LLVMErrorTypeId LLVMGetErrorTypeId(LLVMErrorRef Err) {
return reinterpret_cast<ErrorInfoBase *>(Err)->dynamicClassID(); return reinterpret_cast<ErrorInfoBase *>(Err)->dynamicClassID();
} }
Show All 15 Lines