Add a pass to verify that all functions ended up in the
program address space.
Details
Diff Detail
- Repository
- rG LLVM Github Monorepo
Unit Tests
Event Timeline
Patch is looking really good, only suggestions are the adding a test and a couple formatting nitpicks.
llvm/lib/Target/AVR/HarvardCheck/CMakeLists.txt | ||
---|---|---|
1 | Add the prefix AVR to the library name, i.e. libAVRHarvardCheck to make it clear this dylib is a part of the AVR backend. | |
llvm/lib/Target/AVR/HarvardCheck/HarvardCheck.cpp | ||
73 | Remove the m_ prefix from the member field names, as LLVM doesn't use this naming convention. | |
82 | Add a test for the new pass, inside test/CodeGen/AVR for the new pass. The RUN: line can be ; RUN: opt -load libHarvardCheck.dylib --harvard-check -march=avr 2>&1 < %s | FileCheck %s, the test can contain functions in the wrong address space, and the CHECK lines can verify that the correct error messages are generated. |
Add the prefix AVR to the library name, i.e. libAVRHarvardCheck to make it clear this dylib is a part of the AVR backend.