This is an archive of the discontinued LLVM Phabricator instance.

[CodeGen] Use the common semantic for fixed-point codegen, not the result semantic.
ClosedPublic

Authored by ebevhan on Jun 26 2020, 9:11 AM.

Details

Summary

Using the result semantic is wrong in some cases, such as
unsigned fixed-point + signed integer. In this case, the
result semantic is unsigned and the common semantic is
signed.

Diff Detail

Event Timeline

ebevhan created this revision.Jun 26 2020, 9:11 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 26 2020, 9:11 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
leonardchan accepted this revision.Jun 26 2020, 10:27 AM

LGTM. Thanks for the fix.

This revision is now accepted and ready to land.Jun 26 2020, 10:27 AM
This revision was automatically updated to reflect the committed changes.