Page MenuHomePhabricator

Improve the detection of iOS/tvOS/watchOS simulator binaries in debugserver and lldb
ClosedPublic

Authored by aprantl on Thu, Jun 25, 5:57 PM.

Details

Summary

This patch improves the heuristics for correctly identifying simulator binaries on Darwin and adds support for simulators running on Apple Silicon.

rdar://problem/64046344

Diff Detail

Event Timeline

aprantl created this revision.Thu, Jun 25, 5:57 PM
jasonmolenda accepted this revision.Mon, Jun 29, 11:03 PM

Sorry for the delay, this looks good to me.

This revision is now accepted and ready to land.Mon, Jun 29, 11:03 PM
davide accepted this revision.Tue, Jun 30, 10:27 AM

Thanks.

This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptTue, Jun 30, 11:25 AM

I guess this is breaking the Green Dragon tests as it's in the blame list: http://lab.llvm.org:8080/green/view/LLDB/job/lldb-cmake/22121/

Failing Tests:
lldb-api.tools/lldb-server.TestAppleSimulatorOSType.py
lldb-api.tools/lldb-server.TestGdbRemoteAttach.py
lldb-api.tools/lldb-server.TestGdbRemoteProcessInfo.py
lldb-api.tools/lldb-server.TestGdbRemoteRegisterState.py
lldb-api.tools/lldb-server.TestGdbRemoteThreadsInStopReply.py
lldb-api.tools/lldb-server.TestLldbGdbServer.py