This is an archive of the discontinued LLVM Phabricator instance.

[AMDGPU] Return restricted number of regs from TTI
ClosedPublic

Authored by rampitec on Jun 19 2020, 9:13 AM.

Details

Summary

This is practically NFC at the moment because nothing really
asks the real number or does anything useful with it.

Diff Detail

Event Timeline

rampitec created this revision.Jun 19 2020, 9:13 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 19 2020, 9:13 AM
arsenm added inline comments.Jun 23 2020, 6:59 AM
llvm/lib/Target/AMDGPU/AMDGPUTargetTransformInfo.cpp
251

Surfacing the reg class ID to IR passes seems problematic

rampitec marked an inline comment as done.Jun 23 2020, 11:49 AM
rampitec added inline comments.
llvm/lib/Target/AMDGPU/AMDGPUTargetTransformInfo.cpp
251

It is already in TTI, we just do not implement it.

Ping. This is mostly NFC for now, but is there any reason to return false info from TTI anyway?

arsenm accepted this revision.Jul 9 2020, 1:53 PM

This is terrible, but if it's already there...

This revision is now accepted and ready to land.Jul 9 2020, 1:53 PM
This revision was automatically updated to reflect the committed changes.