This is an archive of the discontinued LLVM Phabricator instance.

Differential D82146

[builtins] Fix typos in comments
ClosedPublic

Authored by rprichard on Jun 18 2020, 11:35 PM.

Details

Reviewers
kongyi
compnerd
Commits
rG8627190f3107: [builtins] Fix typos in comments

Diff Detail

Unit TestsFailed

TimeTest
60 mslinux > HWAddressSanitizer-x86_64.TestCases::Unknown Unit Message ("")
50 mslinux > HWAddressSanitizer-x86_64.TestCases::Unknown Unit Message ("")
60 mslinux > HWAddressSanitizer-x86_64.TestCases::Unknown Unit Message ("")
70 mslinux > HWAddressSanitizer-x86_64.TestCases::Unknown Unit Message ("")
60 mslinux > HWAddressSanitizer-x86_64.TestCases::Unknown Unit Message ("")
View Full Test Results (597 Failed)

Event Timeline

rprichard created this revision.Jun 18 2020, 11:35 PM
Herald added a project: Restricted Project. · View Herald TranscriptJun 18 2020, 11:35 PM
Herald added a subscriber: Restricted Project. · View Herald Transcript
rprichard added reviewers: kongyi, compnerd.Jun 18 2020, 11:43 PM
Harbormaster failed remote builds in B60941: Diff 271919!Jun 19 2020, 12:29 AM
compnerd accepted this revision.Jun 19 2020, 3:31 PM

Thanks for fixing this!

This revision is now accepted and ready to land.Jun 19 2020, 3:31 PM
Closed by commit rG8627190f3107: [builtins] Fix typos in comments (authored by rprichard). · Explain WhyJun 19 2020, 4:19 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
compiler-rt/
lib/
builtins/
i386/
2 lines
2 lines

Diff 271919

compiler-rt/lib/builtins/i386/floatdidf.S

// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information. // See https://llvm.org/LICENSE.txt for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
#include "../assembly.h" #include "../assembly.h"
// double __floatundidf(du_int a); // double __floatdidf(du_int a);
#ifdef __i386__ #ifdef __i386__
CONST_SECTION CONST_SECTION
.balign 16 .balign 16
twop52: twop52:
.quad 0x4330000000000000 .quad 0x4330000000000000
Show All 28 Lines

compiler-rt/lib/builtins/i386/floatdixf.S

// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information. // See https://llvm.org/LICENSE.txt for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
#include "../assembly.h" #include "../assembly.h"
// float __floatdixf(di_int a); // long double __floatdixf(di_int a);
#ifdef __i386__ #ifdef __i386__
// This routine has some extra memory traffic, loading the 64-bit input via two // This routine has some extra memory traffic, loading the 64-bit input via two
// 32-bit loads, then immediately storing it back to the stack via a single 64-bit // 32-bit loads, then immediately storing it back to the stack via a single 64-bit
// store. This is to avoid a write-small, read-large stall. // store. This is to avoid a write-small, read-large stall.
// However, if callers of this routine can be safely assumed to store the argument // However, if callers of this routine can be safely assumed to store the argument
// via a 64-bt store, this is unnecessary memory traffic, and should be avoided. // via a 64-bt store, this is unnecessary memory traffic, and should be avoided.
Show All 19 Lines