This is an archive of the discontinued LLVM Phabricator instance.

[docs] Clarify semantics of ordered fadd/fmul reductions.
ClosedPublic

Authored by aemerson on Jun 17 2020, 11:15 AM.

Diff Detail

Event Timeline

aemerson created this revision.Jun 17 2020, 11:15 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 17 2020, 11:15 AM
spatel added inline comments.Jun 17 2020, 12:24 PM
llvm/docs/LangRef.rst
15135

"That is, the operation begins with the start value and performs..." ?

15204–15205

Add the corresponding text/example for fmul too?

aemerson marked 2 inline comments as done.Jun 17 2020, 3:22 PM
aemerson added inline comments.
llvm/docs/LangRef.rst
15135

Maybe "the reduction begins with" would be clearer.

15204–15205

Will do.

aemerson updated this revision to Diff 271501.Jun 17 2020, 3:26 PM
aemerson retitled this revision from [docs] Clarify semantics of ordered fadd reductions. to [docs] Clarify semantics of ordered fadd/fmul reductions..
RKSimon accepted this revision.Jun 18 2020, 4:31 AM

LGTM - thank you.

This revision is now accepted and ready to land.Jun 18 2020, 4:31 AM
spatel accepted this revision.Jun 18 2020, 5:16 AM
spatel added inline comments.
llvm/docs/LangRef.rst
15135

Grammar nit: remove comma from "value,"
Similar in the fmul text.

This revision was automatically updated to reflect the committed changes.