Page MenuHomePhabricator

[libcxx/variant] Fix build error for when exceptions disabled.
ClosedPublic

Authored by mpark on Jun 16 2020, 3:15 PM.

Details

Summary

lit -D compile_flags="-fno-exceptions" -sv test/std/utilities/variant

Diff Detail

Event Timeline

mpark created this revision.Jun 16 2020, 3:15 PM
Herald added a project: Restricted Project. · View Herald TranscriptJun 16 2020, 3:15 PM
Herald added a reviewer: Restricted Project. · View Herald Transcript
mpark edited the summary of this revision. (Show Details)Jun 16 2020, 3:20 PM
zoecarver accepted this revision.Jun 16 2020, 3:38 PM
zoecarver added a subscriber: zoecarver.
zoecarver added inline comments.
libcxx/include/variant
1084

Can you put a comment here?

(You still need one of the libc++ maintainers to sign off on this)

mpark updated this revision to Diff 271241.Jun 16 2020, 4:14 PM

Added a comment.

mpark marked an inline comment as done.Jun 16 2020, 4:16 PM
ldionne accepted this revision.Jun 18 2020, 7:12 AM
ldionne added a subscriber: ldionne.

LGTM, thanks.

FYI, the right way of disabling exceptions in the test suite is

<build>/bin/llvm-lit -sv libcxx/test --param enable_exceptions=False

This will set the right Lit feature (no-exceptions).

This revision is now accepted and ready to land.Jun 18 2020, 7:12 AM
This revision was automatically updated to reflect the committed changes.