[GlobalISel] Look through extends etc in CombinerHelper::matchConstantOp

[paquette]

Summary

It's possible to end up with a zext or something in the way of a G_CONSTANT, even pre-legalization. This can happen with memsets.

e.g.

https://godbolt.org/z/Bjc8cw

To make sure we can catch these cases, use getConstantVRegValWithLookThrough instead of mi_match.

llvm/lib/CodeGen/GlobalISel/CombinerHelper.cpp

bool CombinerHelper::matchEqualDefs(const MachineOperand &MOP1,
   // On the off-chance that there's some target instruction feeding into the
   // instruction, let's use produceSameValue instead of isIdenticalTo.
   return Builder.getTII().produceSameValue(*I1, *I2, &MRI);
 }
 
 bool CombinerHelper::matchConstantOp(const MachineOperand &MOP, int64_t C) {
   if (!MOP.isReg())
     return false;
-  int64_t Cst;
-  return mi_match(MOP.getReg(), MRI, m_ICst(Cst)) && Cst == C;
+  // MIPatternMatch doesn't let us look through G_ZEXT etc.
+  auto ValAndVReg = getConstantVRegValWithLookThrough(MOP.getReg(), MRI);
+  return ValAndVReg && ValAndVReg->Value == C;
 }
 
 bool CombinerHelper::replaceSingleDefInstWithOperand(MachineInstr &MI,
                                                      unsigned OpIdx) {
   assert(MI.getNumExplicitDefs() == 1 && "Expected one explicit def?");
   Register OldReg = MI.getOperand(0).getReg();
   Register Replacement = MI.getOperand(OpIdx).getReg();
   assert(canReplaceReg(OldReg, Replacement, MRI) && "Cannot replace register?");

llvm/test/CodeGen/AArch64/GlobalISel/prelegalizercombiner-trivial-arith.mir

bb.1.entry:
     ; CHECK: %op:_(s32) = G_SUB %x, %cst
     ; CHECK: $w0 = COPY %op(s32)
     ; CHECK: RET_ReallyLR implicit $w0
     %x:_(s32) = COPY $w0
     %cst:_(s32) = G_CONSTANT i32 1
     %op:_(s32) = G_SUB %x(s32), %cst
     $w0 = COPY %op(s32)
     RET_ReallyLR implicit $w0
+
+...
+---
+name:            look_through_zext
+tracksRegLiveness: true
+body:             |
+  bb.0:
+    liveins: $x0
+    ; CHECK-LABEL: name: look_through_zext
+    ; CHECK: liveins: $x0
+    ; CHECK: %zero:_(s8) = G_CONSTANT i8 0
+    ; CHECK: %zext_zero:_(s64) = G_ZEXT %zero(s8)
+    ; CHECK: $x0 = COPY %zext_zero(s64)
+    ; CHECK: RET_ReallyLR implicit $x0
+    %zero:_(s8) = G_CONSTANT i8 0
+    %zext_zero:_(s64) = G_ZEXT %zero(s8)
+    %c:_(s64) = G_CONSTANT i64 72340172838076673
+    %mul:_(s64) = G_MUL %c, %zext_zero
+    $x0 = COPY %mul(s64)
+    RET_ReallyLR implicit $x0
 ...