Page MenuHomePhabricator

[llvm/Object] Reimplment basic_symbol_iterator in TapiFile

Authored by JDevlieghere on Jun 11 2020, 11:47 PM.



Use indices into the Symbols vector instead of dereferencing std::vector::end().

NFC modulo the Windows failure:

Diff Detail

Event Timeline

JDevlieghere created this revision.Jun 11 2020, 11:47 PM
Herald added a project: Restricted Project. · View Herald TranscriptJun 11 2020, 11:47 PM
cishida accepted this revision.Jun 11 2020, 11:53 PM

Thanks for fixing this! one nit but LGTM


nit: maybe add a message to notify an out of bounds access?


same here

This revision is now accepted and ready to land.Jun 11 2020, 11:53 PM
This revision was automatically updated to reflect the committed changes.
JDevlieghere marked 2 inline comments as done.