This is an archive of the discontinued LLVM Phabricator instance.

[VE] Support convert instructions in MC layer
ClosedPublic

Authored by kaz7 on Jun 10 2020, 12:00 AM.

Details

Summary

Add CVTSQ/CVTDQ/CVTQD/CVTQS instructions. Add regression tests for
them and other convert instructions of asmparser, mccodeemitter, and
disassembler. In order to add those instructions, support RD operands
in asmparser, mccodeemitter, and disassembler.

Diff Detail

Event Timeline

kaz7 created this revision.Jun 10 2020, 12:00 AM

Few nits.

llvm/lib/Target/VE/VE.h
301

unreachable + return

322

unreachable + return

llvm/lib/Target/VE/VEInstrInfo.td
406

Is this commented out for future implementation?

kaz7 planned changes to this revision.Jun 10 2020, 2:17 AM
kaz7 marked 3 inline comments as done.

Thank you for reviewing. I'll update code soon.

llvm/lib/Target/VE/VEInstrInfo.td
406

Thank you. I was checking the behavior of EncoderMethod for other purpose. I forgot to change it back.

kaz7 updated this revision to Diff 269770.Jun 10 2020, 2:28 AM

Update following suggestions. Thank you.

simoll accepted this revision.Jun 10 2020, 3:21 AM

Thanks!

This revision is now accepted and ready to land.Jun 10 2020, 3:21 AM
This revision was automatically updated to reflect the committed changes.