This is an archive of the discontinued LLVM Phabricator instance.

[NFC][WebAssembly] Add tests for alignment on new SIMD loads
ClosedPublic

Authored by tlively on Jun 5 2020, 1:45 PM.

Details

Summary

The natural alignments for extending and splatting loads had not
previously been tested. It is good to have them tested because they
are non-obvious details in the SIMD spec proposal.

Diff Detail

Event Timeline

tlively created this revision.Jun 5 2020, 1:45 PM
aheejin accepted this revision.Jun 7 2020, 2:40 AM

LGTM.
Nit: NFC usually means code change that does not affect output, so adding more tests is not NFC by that definition.

This revision is now accepted and ready to land.Jun 7 2020, 2:40 AM
This revision was automatically updated to reflect the committed changes.