This is an archive of the discontinued LLVM Phabricator instance.

[analyzer] RegionStore: Prefer to get the default binding over the direct
Needs ReviewPublic

Authored by Charusso on Jun 3 2020, 1:37 AM.

Reviewers

NoQ

Summary

Path

Size

clang/

lib/

StaticAnalyzer/

Core/

4 lines

Show First 20 Lines • Show All 1,939 Lines • ▼ Show 20 Lines	SVal RegionStoreManager::getBindingForObjCIvar(RegionBindingsConstRef B,

return getBindingForLazySymbol(R);		return getBindingForLazySymbol(R);
}		}

SVal RegionStoreManager::getBindingForVar(RegionBindingsConstRef B,		SVal RegionStoreManager::getBindingForVar(RegionBindingsConstRef B,
const VarRegion *R) {		const VarRegion *R) {

// Check if the region has a binding.		// Check if the region has a binding.
if (Optional<SVal> V = B.getDirectBinding(R))		if (Optional<SVal> V = B.getDefaultBinding(R))
return *V;		return *V;

if (Optional<SVal> V = B.getDefaultBinding(R))		if (Optional<SVal> V = B.getDirectBinding(R))
return *V;		return *V;

// Lazily derive a value for the VarRegion.		// Lazily derive a value for the VarRegion.
const VarDecl *VD = R->getDecl();		const VarDecl *VD = R->getDecl();
const MemSpaceRegion *MS = R->getMemorySpace();		const MemSpaceRegion *MS = R->getMemorySpace();

// Arguments are always symbolic.		// Arguments are always symbolic.
if (isa<StackArgumentsSpaceRegion>(MS))		if (isa<StackArgumentsSpaceRegion>(MS))
▲ Show 20 Lines • Show All 692 Lines • Show Last 20 Lines