Page MenuHomePhabricator

[PGO] Enable the working set size scaling under the partial sample PGO.
ClosedPublic

Authored by yamauchi on Jun 1 2020, 10:57 AM.

Diff Detail

Event Timeline

yamauchi created this revision.Jun 1 2020, 10:57 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 1 2020, 10:57 AM
davidxl accepted this revision.Jun 4 2020, 9:36 AM

lgtm

This revision is now accepted and ready to land.Jun 4 2020, 9:36 AM
This revision was automatically updated to reflect the committed changes.

arc adds many unneeded tags from Phabricator. You can drop Reviewers: Subscribers: Tags: and the text Summary: with the following script:

arcfilter () {
  arc amend
  git log -1 --pretty=%B | awk '/Reviewers:|Subscribers:/{p=1} /Reviewed By:|Differential Revision:/{p=0} !p && !/^Summary:$/ {sub(/^Summary: /,"");print}' | git commit --amend --date=now -F -
}

Reviewed By: is considered important by some people (https://lists.llvm.org/pipermail/llvm-dev/2020-January/137889.html). You should keep the tag. (I started to use --date=now because some people find author date != committer date annoying. The committer date is usually what people care.))