Page MenuHomePhabricator

[mlir] Fix Windows build
ClosedPublic

Authored by nicolasvasilache on May 29 2020, 2:34 PM.

Details

Summary

MSVC does not seem to like certain forward declarations.

https://reviews.llvm.org/D80728 introduces an error where
seemingly unrelated .cpp files that include the .h
(but do not otherwise use the class that depends on the forward declaration).

Instead of forward declaration, include the full vector ops definition.

Diff Detail

Event Timeline

Herald added a project: Restricted Project. · View Herald TranscriptMay 29 2020, 2:34 PM
This revision was not accepted when it landed; it landed in state Needs Review.May 29 2020, 4:25 PM
This revision was automatically updated to reflect the committed changes.