This is an archive of the discontinued LLVM Phabricator instance.

Differential D80789

[lldb] Pass -fPIC flag even when DYLIB_ONLY is set
ClosedPublic

Authored by teemperor on May 29 2020, 5:25 AM.

Details

Reviewers
friss
labath
Commits
rGfd0ab3b3eb88: [lldb] Pass -fPIC flag even when DYLIB_ONLY is set
Summary

It seems that when we rewrite a few rules to only build a dylib (i.e., when DYLIB_ONLY is set),
the rule for setting the CFLAGS for the dylib's object file compilation will no longer work. From what I can
see this is because in DYLIB_ONLY mode we pretend to compile the main executable so
the DYLIB_OBJECTS scope is actually never used.

This patch makes -fPIC unstopped if DYLIB_ONLY is set so that -fPIC actually ends up in the
CFLAGS for the dylib object file compilation.

The test for this is D80798 which only compiles on Linux with this patch.

Diff Detail

Event Timeline

teemperor created this revision.May 29 2020, 5:25 AM
Herald added a subscriber: JDevlieghere. · View Herald TranscriptMay 29 2020, 5:25 AM
teemperor edited the summary of this revision. (Show Details)May 29 2020, 7:07 AM
teemperor added a child revision: D80798: [lldb] Make expression lookup find only the first variable in the closest module.
friss accepted this revision.May 29 2020, 7:33 AM

LGTM

This revision is now accepted and ready to land.May 29 2020, 7:33 AM
Closed by commit rGfd0ab3b3eb88: [lldb] Pass -fPIC flag even when DYLIB_ONLY is set (authored by teemperor). · Explain WhyMay 30 2020, 9:31 AM
This revision was automatically updated to reflect the committed changes.
teemperor marked an inline comment as done.
Herald added a project: Restricted Project. · View Herald TranscriptMay 30 2020, 9:31 AM
Herald added a subscriber: lldb-commits. · View Herald Transcript

Revision Contents

PathSize
lldb/
packages/
Python/
lldbsuite/
test/
make/
5 lines

Diff 267461

lldb/packages/Python/lldbsuite/test/make/Makefile.rules

Show First 20 Lines • Show All 651 Lines • ▼ Show 20 Lines
endif endif
#---------------------------------------------------------------------- #----------------------------------------------------------------------
# Make the dylib # Make the dylib
#---------------------------------------------------------------------- #----------------------------------------------------------------------
$(DYLIB_OBJECTS) : CFLAGS += -DCOMPILING_LLDB_TEST_DLL $(DYLIB_OBJECTS) : CFLAGS += -DCOMPILING_LLDB_TEST_DLL
ifneq "$(OS)" "Windows_NT" ifneq "$(OS)" "Windows_NT"
ifeq "$(DYLIB_ONLY)" ""
CFLAGS += -fPIC
CXXFLAGS += -fPIC
else
$(DYLIB_OBJECTS) : CFLAGS += -fPIC $(DYLIB_OBJECTS) : CFLAGS += -fPIC
$(DYLIB_OBJECTS) : CXXFLAGS += -fPIC $(DYLIB_OBJECTS) : CXXFLAGS += -fPIC
endif endif
endif
$(DYLIB_FILENAME) : $(DYLIB_OBJECTS) $(DYLIB_FILENAME) : $(DYLIB_OBJECTS)
ifeq "$(OS)" "Darwin" ifeq "$(OS)" "Darwin"
ifneq "$(FRAMEWORK)" "" ifneq "$(FRAMEWORK)" ""
mkdir -p $(FRAMEWORK).framework/Versions/A/Headers mkdir -p $(FRAMEWORK).framework/Versions/A/Headers
mkdir -p $(FRAMEWORK).framework/Versions/A/Modules mkdir -p $(FRAMEWORK).framework/Versions/A/Modules
mkdir -p $(FRAMEWORK).framework/Versions/A/Resources mkdir -p $(FRAMEWORK).framework/Versions/A/Resources
ifneq "$(FRAMEWORK_MODULES)" "" ifneq "$(FRAMEWORK_MODULES)" ""
▲ Show 20 Lines • Show All 119 Lines • Show Last 20 Lines