This is an archive of the discontinued LLVM Phabricator instance.

Differential D80666

Fix a use-after-free in GetXcodeSDKPath
ClosedPublic

Authored by aprantl on May 27 2020, 2:23 PM.

Details

Reviewers
JDevlieghere
friss
Commits
rGacd8927aff8c: Fix a use-after-free in GetXcodeSDKPath
rGa57a67c59b3f: Fix a use-after-free in GetXcodeSDKPath
Summary

I'm sorry, I just introduced this in https://reviews.llvm.org/D80595. Thanks Jonas for noticing!

Diff Detail

Event Timeline

aprantl created this revision.May 27 2020, 2:23 PM
JDevlieghere accepted this revision.May 27 2020, 2:25 PM
This revision is now accepted and ready to land.May 27 2020, 2:25 PM
Closed by commit rGa57a67c59b3f: Fix a use-after-free in GetXcodeSDKPath (authored by aprantl). · Explain WhyMay 27 2020, 2:43 PM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptMay 27 2020, 2:43 PM

Revision Contents

PathSize
lldb/
source/
Host/
macosx/
objcxx/
5 lines

Diff 266673

lldb/source/Host/macosx/objcxx/HostInfoMacOSX.mm

Context not available.
auto it = g_sdk_path.find(sdk.GetString()); auto it = g_sdk_path.find(sdk.GetString());
if (it != g_sdk_path.end()) if (it != g_sdk_path.end())
return it->second; return it->second;
std::string path = GetXcodeSDK(sdk); auto it_new = g_sdk_path.insert({sdk.GetString(), GetXcodeSDK(sdk)});
g_sdk_path.insert({sdk.GetString(), path}); return it_new.first->second;
return path;
} }
Context not available.