This is an archive of the discontinued LLVM Phabricator instance.

Also cache negative results in GetXcodeSDKPath (NFC)
ClosedPublic

Authored by aprantl on May 26 2020, 3:42 PM.

Reviewers

JDevlieghere
friss

Commits

Summary

This fixes a performance issue in the failure case.

rdar://63547920

This revision is now accepted and ready to land.May 27 2020, 11:24 AM

This revision was automatically updated to reflect the committed changes.

Path

Size

lldb/

source/

Host/

macosx/

objcxx/

8 lines

Show First 20 Lines • Show All 361 Lines • ▼ Show 20 Lines	static std::string GetXcodeSDK(XcodeSDK sdk) {
return path;		return path;
}		}

llvm::StringRef HostInfoMacOSX::GetXcodeSDKPath(XcodeSDK sdk) {		llvm::StringRef HostInfoMacOSX::GetXcodeSDKPath(XcodeSDK sdk) {
static llvm::StringMap<std::string> g_sdk_path;		static llvm::StringMap<std::string> g_sdk_path;
static std::mutex g_sdk_path_mutex;		static std::mutex g_sdk_path_mutex;

std::lock_guard<std::mutex> guard(g_sdk_path_mutex);		std::lock_guard<std::mutex> guard(g_sdk_path_mutex);
std::string &path = g_sdk_path[sdk.GetString()];		auto it = g_sdk_path.find(sdk.GetString());
if (path.empty())		if (it != g_sdk_path.end())
path = GetXcodeSDK(sdk);		return it->second;
		std::string path = GetXcodeSDK(sdk);
		g_sdk_path.insert({sdk.GetString(), path});
return path;		return path;
}		}