This is an archive of the discontinued LLVM Phabricator instance.

Fix a use-after-free in GetXcodeSDKPath
ClosedPublic

Authored by aprantl on May 27 2020, 2:23 PM.

Reviewers

JDevlieghere
friss

Commits

Summary

I'm sorry, I just introduced this in https://reviews.llvm.org/D80595. Thanks Jonas for noticing!

This revision is now accepted and ready to land.May 27 2020, 2:25 PM

This revision was automatically updated to reflect the committed changes.

Path

Size

lldb/

source/

Host/

macosx/

objcxx/

5 lines

	Show First 20 Lines • Show All 364 Lines • ▼ Show 20 Lines
	llvm::StringRef HostInfoMacOSX::GetXcodeSDKPath(XcodeSDK sdk) {			llvm::StringRef HostInfoMacOSX::GetXcodeSDKPath(XcodeSDK sdk) {
	static llvm::StringMap<std::string> g_sdk_path;			static llvm::StringMap<std::string> g_sdk_path;
	static std::mutex g_sdk_path_mutex;			static std::mutex g_sdk_path_mutex;

	std::lock_guard<std::mutex> guard(g_sdk_path_mutex);			std::lock_guard<std::mutex> guard(g_sdk_path_mutex);
	auto it = g_sdk_path.find(sdk.GetString());			auto it = g_sdk_path.find(sdk.GetString());
	if (it != g_sdk_path.end())			if (it != g_sdk_path.end())
	return it->second;			return it->second;
	std::string path = GetXcodeSDK(sdk);			auto it_new = g_sdk_path.insert({sdk.GetString(), GetXcodeSDK(sdk)});
	g_sdk_path.insert({sdk.GetString(), path});			return it_new.first->second;
	return path;
	}			}