This is an archive of the discontinued LLVM Phabricator instance.

[libc++] Turn off formatting of files generated by generate_feature_test_macro_components.py. NFC
AbandonedPublic

Authored by curdeius on May 22 2020, 7:58 AM.

Details

Reviewers
ldionne
Group Reviewers
Restricted Project
Summary

These files produce lots of noise in pre-merge checks and when linting. As they are generated, it makes no sense to warn about formatting changes in them.

Diff Detail

Event Timeline

curdeius created this revision.May 22 2020, 7:58 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 22 2020, 7:58 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript

Instead, I would actually like to clang-format libcxx. Can we endure this pain a bit longer until we clang-format the code base? We should start a thread on libcxx-dev.

Ok, fair enough. I'll abandon this revision then.
Should we then update .clang-format (at least for the directory where auto-generated tests are) or update the python script so that it matches libc++ style?
For the former, IndentPPDirectives should be set to AfterHash.

For clang-formatting libc++, are there any plans when it will be done? How may I help?

Ok, fair enough. I'll abandon this revision then.
Should we then update .clang-format (at least for the directory where auto-generated tests are) or update the python script so that it matches libc++ style?
For the former, IndentPPDirectives should be set to AfterHash.

Agreed.

For clang-formatting libc++, are there any plans when it will be done? How may I help?

There are no set-in-stone plans, however I would welcome changes to the .clang-format that make it work for our usage, and then we could clang-format the whole code base (and add the commit to .git-blame-ignore-revs). So if you'd like to help, you could open a review that tweaks the .clang-format with what you think is necessary, and then we can iterate on that. I'll try clang-formatting everything just now to see how much of a mess it creates.

If we think we can move forward with clang-formatting everything, I can send a message to the list for discussion.

curdeius abandoned this revision.May 25 2020, 1:36 PM

Ok. I'll create another revision with necessary .clang-format (and related) changes.