These files produce lots of noise in pre-merge checks and when linting. As they are generated, it makes no sense to warn about formatting changes in them.
Details
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
Instead, I would actually like to clang-format libcxx. Can we endure this pain a bit longer until we clang-format the code base? We should start a thread on libcxx-dev.
Ok, fair enough. I'll abandon this revision then.
Should we then update .clang-format (at least for the directory where auto-generated tests are) or update the python script so that it matches libc++ style?
For the former, IndentPPDirectives should be set to AfterHash.
For clang-formatting libc++, are there any plans when it will be done? How may I help?
Agreed.
For clang-formatting libc++, are there any plans when it will be done? How may I help?
There are no set-in-stone plans, however I would welcome changes to the .clang-format that make it work for our usage, and then we could clang-format the whole code base (and add the commit to .git-blame-ignore-revs). So if you'd like to help, you could open a review that tweaks the .clang-format with what you think is necessary, and then we can iterate on that. I'll try clang-formatting everything just now to see how much of a mess it creates.
If we think we can move forward with clang-formatting everything, I can send a message to the list for discussion.