Page MenuHomePhabricator

[lldb] Allows customizing libxml2 for darwin
ClosedPublic

Authored by hhb on Tue, May 19, 4:03 PM.

Details

Summary

This changes allows to disable or use customized libxml2 for lldb.

  1. Removes redundant include_directories. The one in LLDBConfig.cmake should be enough.
  1. Only link to ${LIBXML2_LIBRARIES} if xml2 is enabled.

Diff Detail

Event Timeline

hhb created this revision.Tue, May 19, 4:03 PM
Herald added a project: Restricted Project. · View Herald TranscriptTue, May 19, 4:03 PM
hhb updated this revision to Diff 265080.Tue, May 19, 4:17 PM

Remove endif()

hhb edited the summary of this revision. (Show Details)Tue, May 19, 4:27 PM
hhb updated this revision to Diff 265082.Tue, May 19, 4:29 PM

rebase

labath accepted this revision.Tue, May 19, 11:32 PM

Yes, that's a lot cleaner.

A better way to ensure lldb is not accidentally built without xml support is to set LLDB_ENABLE_LIBXML=On in the cmake config/cache file.

This revision is now accepted and ready to land.Tue, May 19, 11:32 PM
This revision was automatically updated to reflect the committed changes.