This is an archive of the discontinued LLVM Phabricator instance.

Add AIX to the test macro-same-context XFAIL list
ClosedPublic

Authored by ShuhongL on May 19 2020, 1:14 PM.

Details

Summary

Since the integrated assembly parser was not implemented yet for AIX and macro is not part of the native assembly dialect on AIX, the test macro-same-context is expected to fail for AIX; hence added AIX to XFAIL list.

Diff Detail

Event Timeline

ShuhongL created this revision.May 19 2020, 1:14 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 19 2020, 1:14 PM

The comment about integrated assembler was not implemented for AIX is not exact correct.
You could still get reasonable object file generation for AIX with -fintegrated-as option turn on.
I think you meant the "assembly parser for AIX is not implemented yet."

It may make sense to document in the commit message that .macro is not part of the native assembly dialect on AIX, but either the test would work (and we will update it when lit reports it) or a separate test would be put into place to verify that .macro is diagnosed as not being a valid directive.

ShuhongL updated this revision to Diff 265339.May 20 2020, 1:48 PM
ShuhongL edited the summary of this revision. (Show Details)
ShuhongL added a reviewer: jasonliu.

added comment: macro is not part of the native assembly dialect on AIX

This revision is now accepted and ready to land.May 21 2020, 8:25 AM
This revision was automatically updated to reflect the committed changes.