Page MenuHomePhabricator

ValueMapper does not preserve inline assembly dialect when remapping the type

Authored by Amanieu on Sat, May 16, 12:15 PM.

Diff Detail

Event Timeline

Amanieu created this revision.Sat, May 16, 12:15 PM
Herald added a project: Restricted Project. · View Herald TranscriptSat, May 16, 12:15 PM

Is it possible to write a test for this?

Amanieu added a subscriber: tm.Sat, May 16, 3:16 PM

I'm not exactly sure. The original Rust bug report is pretty hard to extract since it seems to heavily depend on how rustc is splitting code into codegen units.

This revision is now accepted and ready to land.Sat, May 16, 4:52 PM

I don't have commit access, could you please commit this for me?

This revision was automatically updated to reflect the committed changes.