This is an archive of the discontinued LLVM Phabricator instance.

Differential D79989

[NFC] Whitespace fix inside OptParserEmitter
ClosedPublic

Authored by dang on May 15 2020, 2:42 AM.

Details

Reviewers
Bigcheese
dexonsmith

Diff Detail

Event Timeline

dang created this revision.May 15 2020, 2:42 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 15 2020, 2:42 AM
Herald added a subscriber: llvm-commits. · View Herald Transcript
Harbormaster completed remote builds in B56837: Diff 264193.May 15 2020, 4:30 AM
dexonsmith accepted this revision.May 15 2020, 11:23 AM

LGTM. I can commit for you.

This revision is now accepted and ready to land.May 15 2020, 11:23 AM
dexonsmith closed this revision.May 15 2020, 11:27 AM

Committed in 558db27c4971cedde1a5915f390a7897e3038e10.

Revision Contents

PathSize
llvm/
utils/
TableGen/
4 lines

Diff 264193

llvm/utils/TableGen/OptParserEmitter.cpp

Show First 20 Lines • Show All 96 Lines • ▼ Show 20 Lines for (unsigned i = 0, e = Groups.size(); i != e; ++i) {
// The option prefix; // The option prefix;
OS << "nullptr"; OS << "nullptr";
// The option string. // The option string.
OS << ", \"" << R.getValueAsString("Name") << '"'; OS << ", \"" << R.getValueAsString("Name") << '"';
// The option identifier name. // The option identifier name.
OS << ", "<< getOptionName(R); OS << ", " << getOptionName(R);
// The option kind. // The option kind.
OS << ", Group"; OS << ", Group";
// The containing option group (if any). // The containing option group (if any).
OS << ", "; OS << ", ";
if (const DefInit *DI = dyn_cast<DefInit>(R.getValueInit("Group"))) if (const DefInit *DI = dyn_cast<DefInit>(R.getValueInit("Group")))
OS << getOptionName(*DI->getDef()); OS << getOptionName(*DI->getDef());
Show All 30 Lines for (unsigned i = 0, e = Opts.size(); i != e; ++i) {
// The option prefix; // The option prefix;
std::vector<StringRef> prf = R.getValueAsListOfStrings("Prefixes"); std::vector<StringRef> prf = R.getValueAsListOfStrings("Prefixes");
OS << Prefixes[PrefixKeyT(prf.begin(), prf.end())] << ", "; OS << Prefixes[PrefixKeyT(prf.begin(), prf.end())] << ", ";
// The option string. // The option string.
write_cstring(OS, R.getValueAsString("Name")); write_cstring(OS, R.getValueAsString("Name"));
// The option identifier name. // The option identifier name.
OS << ", "<< getOptionName(R); OS << ", " << getOptionName(R);
// The option kind. // The option kind.
OS << ", " << R.getValueAsDef("Kind")->getValueAsString("Name"); OS << ", " << R.getValueAsDef("Kind")->getValueAsString("Name");
// The containing option group (if any). // The containing option group (if any).
OS << ", "; OS << ", ";
const ListInit *GroupFlags = nullptr; const ListInit *GroupFlags = nullptr;
if (const DefInit *DI = dyn_cast<DefInit>(R.getValueInit("Group"))) { if (const DefInit *DI = dyn_cast<DefInit>(R.getValueInit("Group"))) {
▲ Show 20 Lines • Show All 99 Lines • Show Last 20 Lines