This is an archive of the discontinued LLVM Phabricator instance.

[Fuchsia] Do not enable the Z3 solver for a fuchsia toolchain
ClosedPublic

Authored by leonardchan on May 14 2020, 3:52 PM.

Details

Summary

Some workstations may not be using a compatible version of Z3, leading to:

[118/3622] Building CXX object lib/Support/CMakeFiles/LLVMSupport.dir/Z3Solver.cpp.o
FAILED: lib/Support/CMakeFiles/LLVMSupport.dir/Z3Solver.cpp.o 
/usr/local/google/home/leonardchan/goma/gomacc /usr/local/google/home/leonardchan/llvm-monorepo/llvm-build-3-two-stage-fuchsia-toolchain/./bin/clang++ --sysroot=/usr/local/google/home/leonardchan/sysroot/linux-amd64  -DGTEST_HAS_RTTI=0 -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -Ilib/Support -I/usr/local/google/home/leonardchan/llvm-monorepo/llvm-project-3/llvm/lib/Support -I/usr/local/google/home/leonardchan/misc/libxml2-install/include/libxml2 -Iinclude -I/usr/local/google/home/leonardchan/llvm-monorepo/llvm-project-3/llvm/include -I/usr/local/google/home/leonardchan/misc/zlib-install/include -fPIC -fvisibility-inlines-hidden -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -pedantic -Wno-long-long -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wno-comment -Wstring-conversion -fdiagnostics-color -ffunction-sections -fdata-sections -flto -ffile-prefix-map=/usr/local/google/home/leonardchan/llvm-monorepo/llvm-build-3-two-stage-fuchsia-toolchain/tools/clang/stage2-bins=../llvm-build-3-two-stage-fuchsia-toolchain/tools/clang/stage2-bins -ffile-prefix-map=/usr/local/google/home/leonardchan/llvm-monorepo/llvm-project-3/= -no-canonical-prefixes -O3 -DNDEBUG   -std=c++14  -fno-exceptions -fno-unwind-tables -fno-asynchronous-unwind-tables -fno-rtti -MD -MT lib/Support/CMakeFiles/LLVMSupport.dir/Z3Solver.cpp.o -MF lib/Support/CMakeFiles/LLVMSupport.dir/Z3Solver.cpp.o.d -o lib/Support/CMakeFiles/LLVMSupport.dir/Z3Solver.cpp.o -c /usr/local/google/home/leonardchan/llvm-monorepo/llvm-project-3/llvm/lib/Support/Z3Solver.cpp
/usr/local/google/home/leonardchan/llvm-monorepo/llvm-project-3/llvm/lib/Support/Z3Solver.cpp:18:10: fatal error: 'z3.h' file not found
#include <z3.h>
         ^~~~~~
1 error generated.

when building locally. Our prod clang builders don't seem to be using this, so we don't need this locally either.

Diff Detail

Event Timeline

leonardchan created this revision.May 14 2020, 3:52 PM
phosek accepted this revision.May 14 2020, 3:54 PM

LGTM, don't forget to include full context with your patches.

This revision is now accepted and ready to land.May 14 2020, 3:54 PM
This revision was automatically updated to reflect the committed changes.